refactor(lint): improve error handling and code consistency across multiple files

Author: LinkinStars

.golangci.yaml

@@ -17,7 +17,18 @@
 
 version: "2"
 linters:
-  default: none
+  exclusions:
+    paths:
+      - answer-data
+      - ui
+      - i18n
+  enable:
+    - asasalint # checks for pass []any as any in variadic func(...any)
+    - asciicheck # checks that your code does not contain non-ASCII identifiers
+    - bidichk # checks for dangerous unicode character sequences
+    - bodyclose # checks whether HTTP response body is closed successfully
+    - canonicalheader # checks whether net/http.Header uses canonical header
+    - copyloopvar # detects places where loop variables are copied (Go 1.22+)
 
 formatters:
   enable:

cmd/wire.go

@@ -1,5 +1,4 @@
 //go:build wireinject
-// +build wireinject
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
@@ -32,7 +31,7 @@ import (
 	"github.com/apache/answer/internal/base/server"
 	"github.com/apache/answer/internal/base/translator"
 	"github.com/apache/answer/internal/controller"
-	"github.com/apache/answer/internal/controller/template_render"
+	templaterender "github.com/apache/answer/internal/controller/template_render"
 	"github.com/apache/answer/internal/controller_admin"
 	"github.com/apache/answer/internal/repo"
 	"github.com/apache/answer/internal/router"

internal/base/conf/conf.go

@@ -117,7 +117,9 @@ func ReadConfig(configFilePath string) (c *AllConfig, err error) {
 func RewriteConfig(configFilePath string, allConfig *AllConfig) error {
 	buf := bytes.Buffer{}
 	enc := yaml.NewEncoder(&buf)
-	defer enc.Close()
+	defer func() {
+		_ = enc.Close()
+	}()
 	enc.SetIndent(2)
 	if err := enc.Encode(allConfig); err != nil {
 		return err

internal/base/constant/ctx_flag.go

@@ -23,3 +23,10 @@ const (
 	AcceptLanguageFlag = "Accept-Language"
 	ShortIDFlag        = "Short-ID-Enabled"
 )
+
+type ContextKey string
+
+const (
+	AcceptLanguageContextKey ContextKey = ContextKey(AcceptLanguageFlag)
+	ShortIDContextKey        ContextKey = ContextKey(ShortIDFlag)
+)

internal/base/data/data.go

@@ -47,7 +47,7 @@ type Data struct {
 func NewData(db *xorm.Engine, cache cache.Cache) (*Data, func(), error) {
 	cleanup := func() {
 		log.Info("closing the data resources")
-		db.Close()
+		_ = db.Close()
 	}
 	return &Data{DB: db, Cache: cache}, cleanup, nil
 }

internal/base/handler/lang.go

@@ -38,7 +38,7 @@ func GetLang(ctx *gin.Context) i18n.Language {
 
 // GetLangByCtx get language from header
 func GetLangByCtx(ctx context.Context) i18n.Language {
-	acceptLanguage, ok := ctx.Value(constant.AcceptLanguageFlag).(i18n.Language)
+	acceptLanguage, ok := ctx.Value(constant.AcceptLanguageContextKey).(i18n.Language)
 	if ok {
 		return acceptLanguage
 	}

internal/base/handler/short_id.go

@@ -27,7 +27,7 @@ import (
 
 // GetEnableShortID get language from header
 func GetEnableShortID(ctx context.Context) bool {
-	flag, ok := ctx.Value(constant.ShortIDFlag).(bool)
+	flag, ok := ctx.Value(constant.ShortIDContextKey).(bool)
 	if ok {
 		return flag
 	}

internal/base/server/http_funcmap.go

@@ -21,7 +21,6 @@ package server
 
 import (
 	"html/template"
-	"math"
 	"regexp"
 	"strconv"
 	"strings"
@@ -107,15 +106,15 @@ var funcMap = template.FuncMap{
 		}
 
 		if between >= 60 && between < 3600 {
-			min := math.Floor(float64(between / 60))
+			min := between / 60
 			trans = translator.GlobalTrans.Tr(la, "ui.dates.x_minutes_ago")
-			return strings.ReplaceAll(trans, "{{count}}", strconv.FormatFloat(min, 'f', 0, 64))
+			return strings.ReplaceAll(trans, "{{count}}", strconv.FormatInt(min, 10))
 		}
 
 		if between >= 3600 && between < 3600*24 {
-			h := math.Floor(float64(between / 3600))
+			h := between / 3600
 			trans = translator.GlobalTrans.Tr(la, "ui.dates.x_hours_ago")
-			return strings.ReplaceAll(trans, "{{count}}", strconv.FormatFloat(h, 'f', 0, 64))
+			return strings.ReplaceAll(trans, "{{count}}", strconv.FormatInt(h, 10))
 		}
 
 		if between >= 3600*24 &&

internal/base/validator/validator.go

@@ -142,7 +142,7 @@ func Sanitizer(fl validator.FieldLevel) (res bool) {
 	switch field.Kind() {
 	case reflect.String:
 		filter := bluemonday.UGCPolicy()
-		content := strings.Replace(filter.Sanitize(field.String()), "&", "&", -1)
+		content := strings.ReplaceAll(filter.Sanitize(field.String()), "&", "&")
 		field.SetString(content)
 		return true
 	case reflect.Chan, reflect.Map, reflect.Slice, reflect.Array:

internal/cli/build.go

@@ -34,7 +34,6 @@ import (
 	"github.com/Masterminds/semver/v3"
 	"github.com/apache/answer/pkg/dir"
 	"github.com/apache/answer/pkg/writer"
-	"github.com/apache/answer/ui"
 	"github.com/segmentfault/pacman/log"
 	"gopkg.in/yaml.v3"
 )
@@ -300,50 +299,6 @@ func copyUIFiles(b *buildingMaterial) (err error) {
 	return nil
 }
 
-// overwriteIndexTs overwrites index.ts file in ui/src/plugins/ dir
-func overwriteIndexTs(b *buildingMaterial) (err error) {
-	localUIPluginDir := filepath.Join(b.tmpDir, "vendor/github.com/apache/answer/ui/src/plugins/")
-
-	folders, err := getFolders(localUIPluginDir)
-	if err != nil {
-		return fmt.Errorf("failed to get folders: %w", err)
-	}
-
-	content := generateIndexTsContent(folders)
-	err = os.WriteFile(filepath.Join(localUIPluginDir, "index.ts"), []byte(content), 0644)
-	if err != nil {
-		return fmt.Errorf("failed to write index.ts: %w", err)
-	}
-	return nil
-}
-
-func getFolders(dir string) ([]string, error) {
-	var folders []string
-	files, err := os.ReadDir(dir)
-	if err != nil {
-		return nil, err
-	}
-	for _, file := range files {
-		if file.IsDir() && file.Name() != "builtin" {
-			folders = append(folders, file.Name())
-		}
-	}
-	return folders, nil
-}
-
-func generateIndexTsContent(folders []string) string {
-	builder := &strings.Builder{}
-	builder.WriteString("export default null;\n")
-	// Line 2:1:  Delete `⏎`  prettier/prettier
-	if len(folders) > 0 {
-		builder.WriteString("\n")
-	}
-	for _, folder := range folders {
-		builder.WriteString(fmt.Sprintf("export { default as %s } from '%s';\n", folder, folder))
-	}
-	return builder.String()
-}
-
 // buildUI run pnpm install and pnpm build commands to build ui
 func buildUI(b *buildingMaterial) (err error) {
 	localUIBuildDir := filepath.Join(b.tmpDir, "vendor/github.com/apache/answer/ui")
@@ -362,13 +317,6 @@ func buildUI(b *buildingMaterial) (err error) {
 	return nil
 }
 
-func replaceNecessaryFile(b *buildingMaterial) (err error) {
-	fmt.Printf("try to replace ui build directory\n")
-	uiBuildDir := filepath.Join(b.tmpDir, "vendor/github.com/apache/answer/ui")
-	err = copyDirEntries(ui.Build, ".", uiBuildDir)
-	return err
-}
-
 // mergeI18nFiles merge i18n files
 func mergeI18nFiles(b *buildingMaterial) (err error) {
 	fmt.Printf("try to merge i18n files\n")