Dates are being deserialized with kind Local (with potential fix)

[crochik]

Noticed yesterday that dates were coming back with kind Local.

It is my understanding dates from salesforce are all provided as UTC but because of their format (e.g. 2017-05-30T21:10:25.000+0000) the JsonConvert.DeserializeObject by default will attempt some kind of conversion to Local.

It seems like a simple fix (that worked for me):

In JsonClient.cs wherever the JsonConvert.DeserializeObject<T>(...) is being used to deserialize the response, replace with:

JsonConvert.DeserializeObject<T>(..., new JsonSerializerSettings { DateTimeZoneHandling = DateTimeZoneHandling.Utc })

[anthonyreilly]

Are you using DateTime or DateTimeOffset in your model objects? I did a quick test and DateTimeOffset is parsing correctly. I'll see if I can add that change without breaking DateTimeOffset parsing.

[crochik]

hi @anthonyreilly. I actually don't define models and use the ExpandoObject so the JsonConvert will create DateTime properties for Date looking properties.

[anthonyreilly]

hi @anthonyreilly. I actually don't define models and use the ExpandoObject so the JsonConvert will create DateTime properties for Date looking properties.

Thanks, I'm writing some tests now, so I'll include an ExpandoObject case as well