fix(autocomplete): show dropdown on top only when there is room (#11575)

marosoft · mmalerba · commit 8d965aaa1565 · 2019-01-05T14:48:32.000-08:00
Don't use the bounding rectangles of a document body to determine the position of the dropdown. Top and bottom values of the snap element are relative to the viewport, which is enough to decide about the position of the dropdown. Fixes #10859
diff --git a/src/components/autocomplete/js/autocompleteController.js b/src/components/autocomplete/js/autocompleteController.js
@@ -140,7 +140,7 @@ function MdAutocompleteCtrl ($scope, $element, $mdUtil, $mdConstant, $mdTheming,
 
     // Automatically determine dropdown placement based on available space in viewport.
     if (!position) {
-      position = (top > bot && root.height - top - MENU_PADDING < dropdownHeight) ? 'top' : 'bottom';
+      position = (vrect.top + MENU_PADDING > dropdownHeight) ? 'top' : 'bottom';
     }
     // Adjust the width to account for the padding provided by `md-input-container`
     if ($attrs.mdFloatingLabel) {

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ function MdAutocompleteCtrl ($scope, $element, $mdUtil, $mdConstant, $mdTheming,`
`140`	`140`
`141`	`141`	`// Automatically determine dropdown placement based on available space in viewport.`
`142`	`142`	`if (!position) {`
`143`		`- position = (top > bot && root.height - top - MENU_PADDING < dropdownHeight) ? 'top' : 'bottom';`
	`143`	`+ position = (vrect.top + MENU_PADDING > dropdownHeight) ? 'top' : 'bottom';`
`144`	`144`	`}`
`145`	`145`	// Adjust the width to account for the padding provided by `md-input-container`
`146`	`146`	`if ($attrs.mdFloatingLabel) {`