Skip to content

Commit f971cbf

Browse files
build: update repository locations for bazel rules (#32911)
* build: update repository locations for bazel rules The repositories for `rules_sass`, `rules_angular`, and `rules_browsers` were recently transferred from devversion to the angular organization. This commit updates the internal bazel module rules to rely on the new repository locations. * fixup! build: update repository locations for bazel rules
1 parent 439cd88 commit f971cbf

28 files changed

Lines changed: 72 additions & 97 deletions

MODULE.bazel

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,22 @@ bazel_dep(name = "bazel_skylib", version = "1.9.0")
1818
bazel_dep(name = "rules_browsers")
1919
git_override(
2020
module_name = "rules_browsers",
21-
commit = "a520959a60cbe2c0c14326cc368facf1d52daecd",
22-
remote = "https://github.com/devversion/rules_browsers.git",
21+
commit = "7043f918640169063a6281ab4afb61389a0aad6d",
22+
remote = "https://github.com/angular/rules_browsers.git",
2323
)
2424

2525
bazel_dep(name = "rules_sass")
2626
git_override(
2727
module_name = "rules_sass",
28-
commit = "1184a80751a21af8348f308abc5b38a41f26850e",
29-
remote = "https://github.com/devversion/rules_sass.git",
28+
commit = "9135eeae8b8f31d432d44cc46bfa5a8edfa04c47",
29+
remote = "https://github.com/angular/rules_sass.git",
3030
)
3131

3232
bazel_dep(name = "rules_angular")
3333
git_override(
3434
module_name = "rules_angular",
35-
commit = "d746c4f75e42cffe389d1ab077f4639be2bc78d1",
36-
remote = "https://github.com/devversion/rules_angular.git",
35+
commit = "2fe6d3b563c12fbdc32bb30fb21e9c8ca86fdcd2",
36+
remote = "https://github.com/angular/rules_angular.git",
3737
)
3838

3939
bazel_dep(name = "devinfra")

MODULE.bazel.lock

Lines changed: 5 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/aria/listbox/listbox.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,7 @@ describe('Listbox', () => {
691691
});
692692
});
693693

694-
describe('typeahead functionality', () => {
694+
describe(`typeahead functionality (${focusMode})`, () => {
695695
const getOptions = () => [
696696
{value: 0, label: 'Apple', disabled: false},
697697
{value: 1, label: 'Apricot', disabled: false},

src/aria/private/menu/menu.spec.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -344,14 +344,6 @@ describe('Standalone Menu Pattern', () => {
344344
expect(submenu.visible()).toBe(false);
345345
});
346346

347-
it('should close submenu on arrow left', () => {
348-
menu.onKeydown(right());
349-
expect(submenu.visible()).toBe(true);
350-
351-
submenu.onKeydown(left());
352-
expect(submenu.visible()).toBe(false);
353-
});
354-
355347
it('should open submenu on mouseover', async () => {
356348
const menuItem = menu.inputs.items()[0];
357349
menu.onMouseOver({target: menuItem.element()} as unknown as MouseEvent);

src/cdk/a11y/interactivity-checker/interactivity-checker.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ describe('InteractivityChecker', () => {
331331
});
332332
});
333333

334-
it('should return true for div and span with tabindex == 0', () => {
334+
it('isFocusable: should return true for div and span with tabindex == 0', () => {
335335
if (shouldSkip) {
336336
return;
337337
}
@@ -365,7 +365,7 @@ describe('InteractivityChecker', () => {
365365
});
366366
});
367367

368-
it('should return true for div and span with tabindex == 0', () => {
368+
it('isTabbable: should return true for div and span with tabindex == 0', () => {
369369
if (shouldSkip) {
370370
return;
371371
}

src/cdk/a11y/live-announcer/live-announcer.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ describe('LiveAnnouncer', () => {
271271
expect(ariaLiveElement.getAttribute('aria-live')).toBe('assertive');
272272
}));
273273

274-
it('should pick up the default politeness from the injection token', fakeAsync(() => {
274+
it('should pick up the default duration from the injection token', fakeAsync(() => {
275275
announcer.announce('Hello');
276276

277277
tick(100);

src/cdk/listbox/listbox.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ describe('CdkOption and CdkListbox', () => {
244244
expect(listbox.value).toEqual(['apple', 'orange', 'banana', 'peach']);
245245
});
246246

247-
it('should add to selection in multi-select listbox', () => {
247+
it('should toggle the option selection when the user clicks an option in multiple selection mode', () => {
248248
const {testComponent, fixture, listbox, options, optionEls} =
249249
setupComponent(ListboxWithOptions);
250250
testComponent.isMultiselectable = true;
@@ -433,7 +433,7 @@ describe('CdkOption and CdkListbox', () => {
433433
expect(fixture.componentInstance.changedOption).toBe(null);
434434
});
435435

436-
it('should not change selection on click of a disabled option', () => {
436+
it('should not change selection on keyboard activation of a disabled option', () => {
437437
const {fixture, testComponent, listbox, listboxEl} = setupComponent(ListboxWithOptions);
438438
listbox.focus();
439439
fixture.detectChanges();

src/cdk/overlay/overlay-directives.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ describe('Overlay directives', () => {
521521
expect(Math.floor(overlayRect.left)).toBe(Math.floor(triggerRect.left) + 20);
522522
});
523523

524-
it('should take the offset from the position', () => {
524+
it('should take the panel class from the position', () => {
525525
fixture.componentInstance.positionOverrides = [
526526
{
527527
originX: 'start',

src/cdk/scrolling/viewport-ruler.zone.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {Subscription} from 'rxjs';
44
import {dispatchFakeEvent} from '../testing/private';
55
import {ViewportRuler} from './viewport-ruler';
66

7-
describe('ViewportRuler', () => {
7+
describe('ViewportRuler (zone)', () => {
88
let viewportRuler: ViewportRuler;
99
let ngZone: NgZone;
1010

src/cdk/table/table.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ describe('CdkTable', () => {
503503
expect(() => fixture.detectChanges()).toThrowError(getTableUnknownDataSourceError().message);
504504
});
505505

506-
it('should throw an error if the data source is not valid', () => {
506+
it('should render only the header if the data source is undefined', () => {
507507
component.dataSource = undefined;
508508
fixture.changeDetectorRef.markForCheck();
509509
fixture.detectChanges();

0 commit comments

Comments
 (0)