Skip to content

Commit 3ba7b8a

Browse files
committed
refactor(@schematics/angular): add TODO comment for flush with maxTurns in fakeAsync migration
1 parent 9fff043 commit 3ba7b8a

2 files changed

Lines changed: 16 additions & 12 deletions

File tree

packages/schematics/angular/refactor/jasmine-vitest/transformers/fake-async-flush.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ export function transformFakeAsyncFlush(node: ts.Node, ctx: RefactorContext): ts
2727

2828
addImportSpecifierRemoval(ctx, 'flush', ANGULAR_CORE_TESTING);
2929

30+
if (node.arguments.length > 0) {
31+
ctx.reporter.recordTodo('flush-max-turns', ctx.sourceFile, node);
32+
addTodoComment(node, 'flush-max-turns');
33+
}
34+
3035
const awaitRunAllTimersAsync = ts.factory.createAwaitExpression(
3136
ts.factory.createCallExpression(
3237
ts.factory.createPropertyAccessExpression(

packages/schematics/angular/refactor/jasmine-vitest/transformers/fake-async-flush_spec.ts

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,18 @@ describe('transformFakeAsyncFlush', () => {
1919
`,
2020
expected: `await vi.runAllTimersAsync();`,
2121
},
22-
// TODO
23-
// {
24-
// description: 'should add TODO comment when flush is called with maxTurns',
25-
// input: `
26-
// import { flush } from '@angular/core/testing';
22+
{
23+
description: 'should add TODO comment when flush is called with maxTurns',
24+
input: `
25+
import { flush } from '@angular/core/testing';
2726
28-
// flush(42);
29-
// `,
30-
// expected: `
31-
// // TODO: vitest-migration: flush(maxTurns) was called but maxTurns parameter is not migrated. Please migrate manually.
32-
// await vi.runAllTimersAsync();
33-
// `,
34-
// },
27+
flush(42);
28+
`,
29+
expected: `
30+
// TODO: vitest-migration: flush(maxTurns) was called but maxTurns parameter is not migrated. Please migrate manually.
31+
await vi.runAllTimersAsync();
32+
`,
33+
},
3534
{
3635
description: 'should add TODO comment when flush return value is used',
3736
input: `

0 commit comments

Comments
 (0)