biome update

Author: Systerr

CHANGELOG.md

@@ -51,14 +51,17 @@ Main feature of that release is full TypeScript support insluding mongoose model
 - **[BREAKING]** Mongoose v9. <https://mongoosejs.com/docs/migrating_to_9.html>.
 - **[BREAKING]** Vitest v4 <https://vitest.dev/guide/migration.html#vitest-4>
 
+---
+## [5.0.0-beta.45]
+- **[BREAKING]** rate-limiter-flexible v9->v10
+- **[BREAKING]** typecript v5->v6
 
 ---
 ## [5.0.0-beta.44]
 
 - **[NEW]** Logout method
 - **[Update]** set model typing
-- **[BREAKING]** rate-limiter-flexible v9->v10
-- **[BREAKING]** typecript v5->v6
+
 
 
 ---

src/modules/AbstractController.ts

@@ -16,8 +16,10 @@ type MiddlewareWithParamsTuple = [
 export type TMiddleware = Array<
   typeof AbstractMiddleware | MiddlewareWithParamsTuple
 >;
+// biome-ignore lint/complexity/noBannedTypes: Route handlers are generic callable values from user controllers
+type RouteHandler = Function;
 type RouteObject = {
-  handler: Function;
+  handler: RouteHandler;
   description?: string;
   middleware?: TMiddleware | null;
   request?: (unknown & { fields: unknown }) | null; // fields part of you magic
@@ -26,7 +28,7 @@ type RouteObject = {
 
 export type RouteParams = {
   [method: string]: {
-    [path: string]: RouteObject | Function;
+    [path: string]: RouteObject | RouteHandler;
   };
 };
 
@@ -92,7 +94,7 @@ class AbstractController extends Base {
      *  Register controller middleware
      */
     for (const middleware of middlewaresInfo) {
-      (this.router[middleware.method as keyof IRouter] as Function)(
+      (this.router[middleware.method as keyof IRouter] as RouteHandler)(
         middleware.path,
         new middleware.MiddlewareFunction(
           this.app,
@@ -121,7 +123,7 @@ class AbstractController extends Base {
         if (Object.prototype.toString.call(routeObject) !== '[object Object]') {
           // for support firect pass function instead of object
           routeObject = {
-            handler: routeObject as unknown as Function,
+            handler: routeObject as unknown as RouteHandler,
             request: null,
             query: null,
             middleware: null,
@@ -164,7 +166,9 @@ class AbstractController extends Base {
         //   `Controller '${this.getConstructorName()}' register function '${fnName}'  for method '${verb}' and path '${path}' Full path '${fullPath}'`,
         // );
 
-        let additionalMiddlewares: any;
+        let additionalMiddlewares:
+          | ReturnType<AbstractMiddleware['getMiddleware']>[]
+          | undefined;
 
         if (routeAdditionalMiddlewares.length > 0) {
           additionalMiddlewares = Array.from(
@@ -174,7 +178,7 @@ class AbstractController extends Base {
           );
         }
 
-        (this.router[verb as keyof IRouter] as Function)(
+        (this.router[verb as keyof IRouter] as RouteHandler)(
           path,
           additionalMiddlewares || [],
           async (req: FrameworkRequest, res: Response, next: NextFunction) => {

src/modules/BaseCli.ts

@@ -189,6 +189,7 @@ class Cli extends Base {
 
     const result = await c.run().catch((e: { stack: unknown }) => {
       this.logger?.error(e.stack);
+      return undefined;
     });
 
     return result;

src/server.ts

@@ -30,7 +30,7 @@ export interface IApp {
   getModel(
     modelName: string,
   ): AbstractModel['mongooseModel'] | false | TBaseModel;
-  runCliCommand(commandName: string): Promise<boolean | void>;
+  runCliCommand(commandName: string): Promise<boolean | undefined>;
   updateConfig(
     configName: string,
     config: Record<string, unknown>,
@@ -473,7 +473,7 @@ class Server {
       ),
     );
     const { transports } = this.app.getConfig('log') as TLogConfig;
-    function IsConstructor(f: Function) {
+    function IsConstructor(f: (...args: never) => unknown) {
       try {
         Reflect.construct(String, [], f);
       } catch {

src/services/cache/Cache.ts

@@ -44,9 +44,9 @@ class Cache extends Base {
    * @param onNotFound callback that will be executed if value not found on cahce
    * @param storeTime how long we should store value on cache
    */
-  async getSetValue(
+  async getSetValue<T = unknown>(
     keyValue: string,
-    onNotFound: () => Promise<any>,
+    onNotFound: () => Promise<T>,
     storeTime = 60 * 5,
   ) {
     await this.whenReady;
@@ -69,11 +69,12 @@ class Cache extends Base {
       }),
     );
 
-    let result = await this.redisClient.get(key);
-    if (!result) {
+    let parsedResult: T | undefined;
+    const cached = await this.redisClient.get(key);
+    if (!cached) {
       this.logger?.verbose(`getSetValueFromCache not found for key ${key}`);
       try {
-        result = await onNotFound();
+        parsedResult = await onNotFound();
       } catch (e) {
         this.logger?.error(`Cache onNotFound for key '${key}' error: ${e}`);
         this.promiseMapping.delete(key);
@@ -83,7 +84,7 @@ class Cache extends Base {
 
       this.redisClient.set(
         key,
-        JSON.stringify(result, (_jsonkey, value) =>
+        JSON.stringify(parsedResult, (_jsonkey, value) =>
           typeof value === 'bigint' ? `${value}n` : value,
         ),
         {
@@ -92,13 +93,13 @@ class Cache extends Base {
       );
     } else {
       this.logger?.verbose(
-        `getSetValueFromCache FROM CACHE key ${key}, value ${result.substring(
+        `getSetValueFromCache FROM CACHE key ${key}, value ${cached.substring(
           0,
           100,
         )}`,
       );
       try {
-        result = JSON.parse(result, (_jsonkey, value) => {
+        parsedResult = JSON.parse(cached, (_jsonkey, value) => {
           if (typeof value === 'string' && /^\d+n$/.test(value)) {
             return BigInt(value.slice(0, value.length - 1));
           }
@@ -111,9 +112,9 @@ class Cache extends Base {
       }
     }
 
-    resolve(result);
+    resolve(parsedResult);
     this.promiseMapping.delete(key);
-    return result;
+    return parsedResult;
   }
 
   /**

src/services/http/middleware/AbstractMiddleware.ts

@@ -47,7 +47,8 @@ class AbstractMiddleware extends Base {
     _req: FrameworkRequest,
     _res: Response,
     next: NextFunction,
-  ): Promise<void | Response> {
+  ): // biome-ignore lint/suspicious/noConfusingVoidType: Express middleware legitimately returns void or Response
+  Promise<void | Response> {
     this.logger?.warn('Middleware is not implemented');
     return next();
   }

src/services/http/middleware/Auth.test.ts

@@ -1,6 +1,11 @@
+import type { Response } from 'express';
 import { beforeAll, describe, expect, it } from 'vitest';
 import { appInstance } from '../../../helpers/appInstance.ts';
+import type { FrameworkRequest } from '../HttpServer.ts';
 import Auth from './Auth.ts';
+import type { GetUserByTokenAppInfo } from './GetUserByToken.ts';
+
+type AuthRequest = FrameworkRequest & GetUserByTokenAppInfo;
 
 describe('atuh middleware methods', () => {
   let middleware: Auth;
@@ -26,7 +31,11 @@ describe('atuh middleware methods', () => {
         user: true,
       },
     };
-    await middleware.middleware(req as any, {} as any, nextFunction);
+    await middleware.middleware(
+      req as unknown as AuthRequest,
+      {} as unknown as Response,
+      nextFunction,
+    );
 
     expect(isCalled).toBeTruthy();
   });
@@ -44,7 +53,7 @@ describe('atuh middleware methods', () => {
       appInfo: {}, // no user
     };
     await middleware.middleware(
-      req as any,
+      req as unknown as AuthRequest,
       {
         status(statusCode: number) {
           status = statusCode;
@@ -54,7 +63,7 @@ describe('atuh middleware methods', () => {
           isSend = true;
           return this;
         },
-      } as any,
+      } as unknown as Response,
       nextFunction,
     );
 

src/services/http/middleware/I18n.test.ts

@@ -3,7 +3,7 @@ import { appInstance } from '../../../helpers/appInstance.ts';
 import I18n from './I18n.ts';
 
 describe('i18n middleware methods', () => {
-  let middleware: any;
+  let middleware: I18n;
 
   beforeAll(() => {
     middleware = new I18n(appInstance);

src/services/logging/SentryTransport.ts

@@ -39,7 +39,7 @@ class SentryTransport extends Transport {
     this.loadSentryTransport(opts);
   }
 
-  private async loadSentryTransport(opts: Transport.TransportStreamOptions) {
+  private async loadSentryTransport(_opts: Transport.TransportStreamOptions) {
     if (this.#initializationAttempted) {
       return;
     }
@@ -54,7 +54,7 @@ class SentryTransport extends Transport {
       this.#sentry = sentry;
 
       console.log('[Framework] Sentry Winston transport loaded successfully');
-    } catch (error) {
+    } catch (_error) {
       // Sentry is not installed - this is fine for a framework
       console.log(
         '[Framework] Sentry Winston transport not available (package not installed)',