Commit c5d7283
Adjust binary encoding of import/export names (#623)
* Adjust binary encoding of import/export names
The purpose of this commit is to address the discrepancy between the
specification and wasm-tools discovered in #622. The history here is:
* #222 - historical addition of `(interface "name")` as an import/export
name.
* #263 - moral revert of the previous change where the kind of name was
now encoded in the name instead. At this point `Binary.md` mistakenly
no longer reflected what wasm-tools parsed.
* #536 - addition of more metadata to import/export names with a
discriminator byte that overlapped the previous.
This commit is is an adjustment to `Binary.md` to fix these
discrepancies. Notably `exportname` and `importname` productions,
previously absent. The `exportname'` and `importname'` productions are
now renamed to `exportname` and `importname`. Additioanlly the
production with `versionsuffix'` have been renumbered to `0x02` while an
`0x01` production was added which is the exact same as `0x00` (intended
for historical compat). A note was updated in the 1.0 binary adjustments
to clean this up.
Closes #622
* Review comments
* Update design/mvp/Binary.md
Co-authored-by: Luke Wagner <mail@lukewagner.name>
---------
Co-authored-by: Luke Wagner <mail@lukewagner.name>1 parent e4965ac commit c5d7283
1 file changed
Lines changed: 11 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
389 | 389 | | |
390 | 390 | | |
391 | 391 | | |
392 | | - | |
393 | | - | |
394 | | - | |
395 | | - | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
396 | 398 | | |
397 | 399 | | |
398 | 400 | | |
| |||
406 | 408 | | |
407 | 409 | | |
408 | 410 | | |
| 411 | + | |
| 412 | + | |
409 | 413 | | |
410 | 414 | | |
411 | 415 | | |
| |||
519 | 523 | | |
520 | 524 | | |
521 | 525 | | |
522 | | - | |
523 | | - | |
524 | | - | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
525 | 529 | | |
526 | 530 | | |
527 | 531 | | |
| |||
0 commit comments