Change protocol parameter to use symbols instead of strings

Co-authored-by: joelhawksley <1940294+joelhawksley@users.noreply.github.com>

Author: Copilot

docs/CHANGELOG.md

@@ -10,6 +10,10 @@ nav_order: 6
 
 ## main
 
+* Add `protocol` parameter to `with_request_url` test helper to enable testing with HTTPS protocol.
+
+    *Joel Hawksley*
+
 ## 4.3.0
 
 * Fix load order issues for 3rd-party template handlers.

lib/view_component/test_helpers.rb

@@ -199,15 +199,15 @@ def with_format(*formats)
     # To specify a protocol, pass the protocol param:
     #
     # ```ruby
-    # with_request_url("/users/42", protocol: "https") do
+    # with_request_url("/users/42", protocol: :https) do
     #   render_inline(MyComponent.new)
     # end
     # ```
     #
     # @param full_path [String] The path to set for the current request.
     # @param host [String] The host to set for the current request.
     # @param method [String] The request method to set for the current request.
-    # @param protocol [String] The protocol to set for the current request (e.g., "http" or "https").
+    # @param protocol [Symbol] The protocol to set for the current request (e.g., `:http` or `:https`).
     def with_request_url(full_path, host: nil, method: nil, protocol: nil)
       old_request_host = vc_test_request.host
       old_request_method = vc_test_request.request_method
@@ -224,7 +224,7 @@ def with_request_url(full_path, host: nil, method: nil, protocol: nil)
       vc_test_request.instance_variable_set(:@original_fullpath, full_path)
       vc_test_request.host = host if host
       vc_test_request.request_method = method if method
-      vc_test_request.set_header(Rack::RACK_URL_SCHEME, protocol) if protocol
+      vc_test_request.set_header(Rack::RACK_URL_SCHEME, protocol.to_s) if protocol
       vc_test_request.path_info = path
       vc_test_request.path_parameters = Rails.application.routes.recognize_path_with_request(vc_test_request, path, {})
       vc_test_request.set_header("action_dispatch.request.query_parameters",

test/sandbox/test/rendering_test.rb

@@ -965,17 +965,17 @@ def test_with_request_url_with_host
   end
 
   def test_with_request_url_with_https_protocol
-    with_request_url "/", protocol: "https" do
+    with_request_url "/", protocol: :https do
       render_inline UrlForComponent.new(only_path: false)
-      assert_text "https://www.example.com/?key=value"
+      assert_text "https://example.com/?key=value"
     end
 
-    with_request_url "/products", protocol: "https", host: "secure.example.com" do
+    with_request_url "/products", protocol: :https, host: "secure.example.com" do
       render_inline UrlForComponent.new(only_path: false)
       assert_text "https://secure.example.com/products?key=value"
     end
 
-    with_request_url "/products", protocol: "https" do
+    with_request_url "/products", protocol: :https do
       assert_equal "https", vc_test_request.scheme
       assert vc_test_request.ssl?
     end

test/sandbox/test/test_helper_test.rb

@@ -51,15 +51,15 @@ def test_vc_test_view_context_is_shared_reference
   end
 
   def test_with_request_url_specifying_http_protocol
-    with_request_url "/products", protocol: "http" do
+    with_request_url "/products", protocol: :http do
       render_inline(ProtocolComponent.new)
     end
 
     assert_selector(".protocol", text: "Protocol: http, SSL: false")
   end
 
   def test_with_request_url_specifying_https_protocol
-    with_request_url "/products", protocol: "https" do
+    with_request_url "/products", protocol: :https do
       render_inline(ProtocolComponent.new)
     end
 
@@ -70,7 +70,7 @@ def test_with_request_url_restores_original_protocol
     # Store original protocol
     original_scheme = vc_test_request.scheme
 
-    with_request_url "/products", protocol: "https" do
+    with_request_url "/products", protocol: :https do
       assert_equal "https", vc_test_request.scheme
     end
 
@@ -79,7 +79,7 @@ def test_with_request_url_restores_original_protocol
   end
 
   def test_with_request_url_with_protocol_and_host
-    with_request_url "/products", protocol: "https", host: "secure.example.com" do
+    with_request_url "/products", protocol: :https, host: "secure.example.com" do
       render_inline(ProtocolComponent.new)
     end