Fix crash when architecture string has no hyphen after colon (#1001)

When connecting to QEMU-PPC targets, the architecture string may be
"powerpc:common" which contains a colon but no hyphen. The code was
calling string::replace() with the result of string::find('-') without
checking if find() returned npos, causing a crash.

This fix adds a check for npos before calling replace() in all three
affected adapter files.

Fixes #1000

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: xusheng6

core/adapters/corelliumadapter.cpp

@@ -137,7 +137,9 @@ bool CorelliumAdapter::LoadRegisterInfo()
 	if (architecture.find(':') != std::string::npos)
 	{
 		architecture.erase(0, architecture.find(':') + 1);
-		architecture.replace(architecture.find('-'), 1, "_");
+		auto hyphenPos = architecture.find('-');
+		if (hyphenPos != std::string::npos)
+			architecture.replace(hyphenPos, 1, "_");
 	}
 	m_remoteArch = architecture;
 

core/adapters/esrevenadapter.cpp

@@ -160,7 +160,9 @@ bool EsrevenAdapter::LoadRegisterInfo()
 	if (architecture.find(':') != std::string::npos)
 	{
 		architecture.erase(0, architecture.find(':') + 1);
-		architecture.replace(architecture.find('-'), 1, "_");
+		auto hyphenPos = architecture.find('-');
+		if (hyphenPos != std::string::npos)
+			architecture.replace(hyphenPos, 1, "_");
 	}
 	m_remoteArch = architecture;
 

core/adapters/gdbadapter.cpp

@@ -160,7 +160,9 @@ bool GdbAdapter::LoadRegisterInfo()
 	if (architecture.find(':') != std::string::npos)
 	{
 		architecture.erase(0, architecture.find(':') + 1);
-		architecture.replace(architecture.find('-'), 1, "_");
+		auto hyphenPos = architecture.find('-');
+		if (hyphenPos != std::string::npos)
+			architecture.replace(hyphenPos, 1, "_");
 	}
 	m_remoteArch = architecture;