Fix #984: Refresh view after TTD coverage analysis completes (#986)

* Fix #984: Refresh view after TTD coverage analysis completes

- Pass UIContext to TTDAnalysisDialog for proper view access
- Add refreshViewAndEnableRenderLayer() method to refresh view
- Call refresh after analysis completes and after loading results
- Verify TTD Coverage render layer is registered

This makes coverage highlights visible immediately after analysis,
assuming the user has the TTD Coverage render layer enabled.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Make TTD Coverage render layer always enabled with fast path

- Change render layer registration to AlwaysEnabled instead of DisabledByDefault
- Add early return check: if GetExecutedInstructionCount() == 0, return immediately
- This makes the layer have zero overhead when there's no coverage data
- Simplify refreshViewAndEnableRenderLayer() method

With these changes:
- Users don't need to manually enable the render layer
- Coverage is visible immediately after analysis completes
- No performance impact when coverage data is not loaded
- Works across all views (linear, graph, etc.)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Various fixes

---------

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: xusheng6

ui/renderlayer.cpp

@@ -405,5 +405,5 @@ void RegisterRenderLayers()
 	static TTDCoverageRenderLayer* g_ttdCoverageRenderLayer = new TTDCoverageRenderLayer();
 
 	RenderLayer::Register(g_debuggerRenderLayer, BNRenderLayerDefaultEnableState::AlwaysEnabledRenderLayerDefaultEnableState);
-	RenderLayer::Register(g_ttdCoverageRenderLayer, BNRenderLayerDefaultEnableState::DisabledByDefaultRenderLayerDefaultEnableState);
+	RenderLayer::Register(g_ttdCoverageRenderLayer, BNRenderLayerDefaultEnableState::EnabledByDefaultRenderLayerDefaultEnableState);
 }

ui/ttdanalysisdialog.cpp

@@ -22,6 +22,8 @@ limitations under the License.
 #include <QJsonDocument>
 #include <QJsonObject>
 #include <QApplication>
+#include "uicontext.h"
+#include "linearview.h"
 
 TTDAnalysisWorker::TTDAnalysisWorker(DbgRef<DebuggerController> controller, TTDAnalysisType type, QObject* parent)
 	: QThread(parent), m_controller(controller), m_analysisType(type), m_useRange(false), m_startAddress(0), m_endAddress(0)
@@ -91,8 +93,8 @@ void TTDAnalysisWorker::run()
 	emit analysisCompleted(success, message, resultCount);
 }
 
-TTDAnalysisDialog::TTDAnalysisDialog(BinaryViewRef data, QWidget* parent)
-	: QDialog(parent), m_data(data), m_currentWorker(nullptr)
+TTDAnalysisDialog::TTDAnalysisDialog(UIContext* context, BinaryViewRef data, QWidget* parent)
+	: QDialog(parent), m_context(context), m_data(data), m_currentWorker(nullptr)
 {
 	m_controller = DebuggerController::GetController(data);
 
@@ -550,6 +552,11 @@ void TTDAnalysisDialog::onAnalysisCompleted(bool success, const QString& message
 	{
 		QMessageBox::warning(this, "Analysis Failed", message);
 	}
+	else
+	{
+		// Refresh the view to make coverage visible immediately
+		refreshView();
+	}
 }
 
 void TTDAnalysisDialog::onSaveResults()
@@ -591,6 +598,9 @@ void TTDAnalysisDialog::onLoadResults()
 
 		populateAnalysisList();
 		QMessageBox::information(this, "Load Results", "Analysis results loaded successfully");
+
+		// Refresh the view to show the loaded coverage
+		refreshView();
 	}
 	else
 	{
@@ -774,3 +784,15 @@ bool TTDAnalysisDialog::loadAnalysisResults(TTDAnalysisResult& result)
 
 	return true;
 }
+
+void TTDAnalysisDialog::refreshView()
+{
+	// Use the stored UI context to refresh the view
+	if (!m_context)
+		return;
+
+	// Refresh the current view contents to show the coverage immediately
+	// The TTD Coverage render layer is always enabled and will automatically
+	// display coverage highlights when coverage data is available
+	m_context->refreshCurrentViewContents();
+}

ui/ttdanalysisdialog.h

@@ -34,6 +34,8 @@ limitations under the License.
 #include <QThread>
 #include <QMutex>
 #include "binaryninjaapi.h"
+#include "uicontext.h"
+#include "viewframe.h"
 #include "debuggerapi.h"
 #include <uitypes.h>
 
@@ -94,7 +96,7 @@ class TTDAnalysisDialog : public QDialog
 	Q_OBJECT
 
 public:
-	TTDAnalysisDialog(BinaryViewRef data, QWidget* parent = nullptr);
+	TTDAnalysisDialog(UIContext* context, BinaryViewRef data, QWidget* parent = nullptr);
 	~TTDAnalysisDialog();
 
 private slots:
@@ -115,7 +117,9 @@ private slots:
 	QString getDefaultCachePath(TTDAnalysisType type);
 	bool saveAnalysisResults(const TTDAnalysisResult& result);
 	bool loadAnalysisResults(TTDAnalysisResult& result);
+	void refreshView();
 
+	UIContext* m_context;
 	BinaryViewRef m_data;
 	DbgRef<DebuggerController> m_controller;
 

ui/ttdcoveragerenderlayer.cpp

@@ -37,6 +37,10 @@ void TTDCoverageRenderLayer::ApplyToBlock(Ref<BasicBlock> block, std::vector<Dis
 	if (!controller->IsTTD())
 		return;
 
+	// Quick check: if no coverage data has been loaded, return immediately
+	if (controller->GetExecutedInstructionCount() == 0)
+		return;
+
 	for (auto& line : lines)
 	{
 		// Do not highlight empty lines or comments
@@ -76,6 +80,10 @@ void TTDCoverageRenderLayer::ApplyToHighLevelILBody(Ref<Function> function, std:
 	if (!controller->IsTTD())
 		return;
 
+	// Quick check: if no coverage data has been loaded, return immediately
+	if (controller->GetExecutedInstructionCount() == 0)
+		return;
+
 	for (auto& linearLine : lines)
 	{
 		DisassemblyTextLine& line = linearLine.contents;

ui/ui.cpp

@@ -1422,7 +1422,7 @@ void GlobalDebuggerUI::SetupMenu(UIContext* context)
 				if (!controller || !controller->IsTTD())
 					return;
 
-				auto dialog = new TTDAnalysisDialog(ctxt.binaryView, nullptr);
+				auto dialog = new TTDAnalysisDialog(ctxt.context, ctxt.binaryView, nullptr);
 				dialog->show();
 				dialog->raise();
 				dialog->activateWindow();