Better prompt message for launching a target during remote debugging (#844)

Author: Copilot

ui/controlswidget.cpp

@@ -180,6 +180,12 @@ void DebugControlsWidget::performLaunch()
 	{
 		isLocalLaunch = false;
 	}
+	
+	// Also consider debug server connections as remote
+	if (m_controller->IsConnectedToDebugServer())
+	{
+		isLocalLaunch = false;
+	}
 
 	if (isLocalLaunch && firstLaunch && Settings::Instance()->Get<bool>("debugger.confirmFirstLaunch"))
 	{
@@ -188,6 +194,16 @@ void DebugControlsWidget::performLaunch()
 		if (QMessageBox::question(this, "Launch Target", prompt) != QMessageBox::Yes)
 			return;
 	}
+	else if (!isLocalLaunch && firstLaunch && Settings::Instance()->Get<bool>("debugger.confirmFirstLaunch"))
+	{
+		auto remoteHost = QString::fromStdString(m_controller->GetRemoteHost());
+		auto remotePort = m_controller->GetRemotePort();
+		auto prompt = QString("You are about to launch \n\n%1\n\non remote host %2:%3. "
+			"Are you sure to continue?").arg(QString::fromStdString(m_controller->GetExecutablePath()))
+			.arg(remoteHost).arg(remotePort);
+		if (QMessageBox::question(this, "Launch Target", prompt) != QMessageBox::Yes)
+			return;
+	}
 
 	auto data = m_controller->GetData();
 	if (!data->GetDefaultPlatform())

ui/ui.cpp

@@ -476,6 +476,12 @@ void GlobalDebuggerUI::SetupMenu(UIContext* context)
 				{
 					isLocalLaunch = false;
 				}
+				
+				// Also consider debug server connections as remote
+				if (controller->IsConnectedToDebugServer())
+				{
+					isLocalLaunch = false;
+				}
 
 				if (isLocalLaunch && firstLaunch && Settings::Instance()->Get<bool>("debugger.confirmFirstLaunch"))
 				{
@@ -485,6 +491,16 @@ void GlobalDebuggerUI::SetupMenu(UIContext* context)
 					if (QMessageBox::question(context->mainWindow(), "Launch Target", prompt) != QMessageBox::Yes)
 						return;
 				}
+				else if (!isLocalLaunch && firstLaunch && Settings::Instance()->Get<bool>("debugger.confirmFirstLaunch"))
+				{
+					auto remoteHost = QString::fromStdString(controller->GetRemoteHost());
+					auto remotePort = controller->GetRemotePort();
+					auto prompt = QString("You are about to launch \n\n%1\n\non remote host %2:%3. "
+						"Are you sure to continue?").arg(QString::fromStdString(controller->GetExecutablePath()))
+						.arg(remoteHost).arg(remotePort);
+					if (QMessageBox::question(context->mainWindow(), "Launch Target", prompt) != QMessageBox::Yes)
+						return;
+				}
 
 				if (!ensureBinaryViewHasPlatform(controller->GetData(), context->mainWindow()))
 					return;