Skip to content

Commit 3bf5b51

Browse files
committed
Remove embedded specific implementations
1 parent 16aaa9d commit 3bf5b51

1 file changed

Lines changed: 1 addition & 11 deletions

File tree

core/adapters/gdbmiadapter.cpp

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -737,11 +737,8 @@ bool GdbMiAdapter::WriteRegister(const std::string& reg, intx::uint512 value) {
737737
DataBuffer GdbMiAdapter::ReadMemory(std::uintptr_t address, size_t size) {
738738
if (!m_mi) return {};
739739
LogDebug("GdbMiAdapter::ReadMemory 0x%lX-0x%lX", address, address+size);
740-
// embedded specifics: we can use 'info mem' to get list of memory regions available for reading.
741-
// it's safe to assume 0x08000000 - 0x60000000 is good enough for most arm-cortex targets
740+
// TODO: we can use 'info mem' to get list of memory regions available for reading.
742741
DataBuffer zero(size);
743-
if (address > 0x60000000) return zero;
744-
if (address < 0x08000000) return zero;
745742

746743
std::string cmd = fmt::format("-data-read-memory-bytes 0x{:x} {}", address, size);
747744
auto result = m_mi->SendCommand(cmd);
@@ -778,13 +775,6 @@ std::vector<DebugModule> GdbMiAdapter::GetModuleList()
778775
return {};
779776

780777
std::vector<DebugModule> modules;
781-
Ref<BinaryView> data = GetData();
782-
if (!data)
783-
return {};
784-
785-
std::string name = data->GetFile()->GetOriginalFilename();
786-
modules.emplace_back("SRAM", "SRAM", 0x20000000, 0x00040000, true);
787-
modules.emplace_back(name, name, 0x08000000, 0x00100000, true);
788778
return modules;
789779
}
790780

0 commit comments

Comments
 (0)