Fix remote debugging launch prompt

Author: xusheng6

ui/controlswidget.cpp

@@ -181,11 +181,7 @@ void DebugControlsWidget::performLaunch()
 		isLocalLaunch = false;
 	}
 
-	// Also consider debug server connections as remote
-	if (m_controller->IsConnectedToDebugServer())
-	{
-		isLocalLaunch = false;
-	}
+	bool connectedToDebugServer = m_controller->IsConnectedToDebugServer();
 
 	if (isLocalLaunch && firstLaunch && Settings::Instance()->Get<bool>("debugger.confirmFirstLaunch"))
 	{
@@ -194,7 +190,8 @@ void DebugControlsWidget::performLaunch()
 		if (QMessageBox::question(this, "Launch Target", prompt) != QMessageBox::Yes)
 			return;
 	}
-	else if (!isLocalLaunch && firstLaunch && Settings::Instance()->Get<bool>("debugger.confirmFirstLaunch"))
+	else if (!isLocalLaunch && connectedToDebugServer &&firstLaunch &&
+		Settings::Instance()->Get<bool>("debugger.confirmFirstLaunch"))
 	{
 		auto remoteHost = QString::fromStdString(m_controller->GetRemoteHost());
 		auto remotePort = m_controller->GetRemotePort();

ui/ui.cpp

@@ -477,11 +477,7 @@ void GlobalDebuggerUI::SetupMenu(UIContext* context)
 					isLocalLaunch = false;
 				}
 
-				// Also consider debug server connections as remote
-				if (controller->IsConnectedToDebugServer())
-				{
-					isLocalLaunch = false;
-				}
+				bool connectedToDebugServer = controller->IsConnectedToDebugServer();
 
 				if (isLocalLaunch && firstLaunch && Settings::Instance()->Get<bool>("debugger.confirmFirstLaunch"))
 				{
@@ -491,7 +487,8 @@ void GlobalDebuggerUI::SetupMenu(UIContext* context)
 					if (QMessageBox::question(context->mainWindow(), "Launch Target", prompt) != QMessageBox::Yes)
 						return;
 				}
-				else if (!isLocalLaunch && firstLaunch && Settings::Instance()->Get<bool>("debugger.confirmFirstLaunch"))
+				else if (!isLocalLaunch && connectedToDebugServer && firstLaunch &&
+					Settings::Instance()->Get<bool>("debugger.confirmFirstLaunch"))
 				{
 					auto remoteHost = QString::fromStdString(controller->GetRemoteHost());
 					auto remotePort = controller->GetRemotePort();