DBO: Drop GetId() it doesn't really make sense

Author: CouleeApps

binaryninjaapi.h

@@ -22406,7 +22406,6 @@ namespace BinaryNinja {
 
 		// TODO: User subclassing
 		int GetType() const;
-		std::string GetId() const;
 		std::string GetDescription() const;
 		Ref<Metadata> GetMetadata() const;
 		Ref<DatabaseObject> GetParent() const;

binaryninjacore.h

@@ -9127,7 +9127,6 @@ extern "C"
 	BINARYNINJACOREAPI void BNFreeDatabaseObject(BNDatabaseObject* object);
 	BINARYNINJACOREAPI void BNFreeDatabaseObjectList(BNDatabaseObject** objects, size_t count);
 	BINARYNINJACOREAPI int BNGetDatabaseObjectType(BNDatabaseObject* object);
-	BINARYNINJACOREAPI char* BNGetDatabaseObjectId(BNDatabaseObject* object);
 	BINARYNINJACOREAPI char* BNGetDatabaseObjectDescription(BNDatabaseObject* object);
 	BINARYNINJACOREAPI BNMetadata* BNGetDatabaseObjectMetadata(BNDatabaseObject* object);
 	BINARYNINJACOREAPI BNDatabaseObject* BNGetDatabaseObjectParent(BNDatabaseObject* object);

merge.cpp

@@ -41,15 +41,6 @@ Ref<DatabaseObject> DatabaseObject::GetParent() const
 }
 
 
-std::string DatabaseObject::GetId() const
-{
-	char* id = BNGetDatabaseObjectId(m_object);
-	std::string result = id;
-	BNFreeString(id);
-	return result;
-}
-
-
 std::string DatabaseObject::GetDescription() const
 {
 	char* desc = BNGetDatabaseObjectDescription(m_object);

python/database.py

@@ -385,11 +385,6 @@ def type(self) -> int:
 		"""Get the database object type (read-only)"""
 		return core.BNGetDatabaseObjectType(self.handle)
 
-	@property
-	def id(self) -> str:
-		"""Get the database object id (read-only)"""
-		return core.BNGetDatabaseObjectId(self.handle)
-
 	@property
 	def description(self) -> str:
 		"""Get the database object description (read-only)"""