FIX: ISXB-1013-prevent-ui-update-loop (#1984)

* Improve ui test CanRenameActionMap to take the scheduler in account

Author: smnwttbr

Assets/Tests/InputSystem.Editor/InputActionsEditorTests.cs

@@ -109,6 +109,8 @@ public IEnumerator CanRenameActionMap()
         m_Window.rootVisualElement.Q<ListView>("action-maps-list-view").Focus();
         m_Window.rootVisualElement.Q<ListView>("action-maps-list-view").selectedIndex = 1;
 
+        // changing the selection triggers a state change, wait for the scheduler to process the frame
+        yield return WaitForSchedulerLoop();
         yield return WaitForNotDirty();
         yield return WaitForFocus(m_Window.rootVisualElement.Q("action-maps-list-view"));
 

Assets/Tests/InputSystem.Editor/UIToolkitBaseTestWindow.cs

@@ -120,6 +120,17 @@ protected void SimulateDeleteCommand()
         m_Window.rootVisualElement.SendEvent(ce);
     }
 
+    /// <summary>
+    /// Wait for UI toolkit scheduler to process the frame
+    /// </summary>
+    /// <param name="timeoutSecs">Maximum time to wait in seconds.</param>
+    protected IEnumerator WaitForSchedulerLoop(double timeoutSecs = 5.0)
+    {
+        bool done = false;
+        m_Window.rootVisualElement.schedule.Execute(() => done = true);
+        return WaitUntil(() => done == true, "WaitForSchedulerLoop", timeoutSecs);
+    }
+
     /// <summary>
     /// Wait for the visual element to be focused
     /// </summary>

Packages/com.unity.inputsystem/CHANGELOG.md

@@ -14,6 +14,7 @@ however, it has to be formatted properly to pass verification tests.
 - Fixed memory allocation on every frame when using UIDocument without EventSystem. [ISXB-953](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-953)
 - Fixed Action Maps name edition which could be inconsistent in Input Action Editor UI.
 - Fixed InputDeviceTester sample only visualizing a given touch contact once. [ISXB-1017](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1017)
+- Fixed an update loop in the asset editor that occurs when selecting an Action Map that has no Actions.
 - Fixed Package compilation when Unity Analytics module is not enabled on 2022.3. [ISXB-996](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-996)
 
 ### Added