FIX: Serialized InputAction's Processor properties dropdown doesn't work inside the Inspector (ISXB-1269) (#2072)

bmalrat · web-flow · commit 4b4ed008c000 · 2024-12-06T11:49:44.000-05:00
diff --git a/Packages/com.unity.inputsystem/CHANGELOG.md b/Packages/com.unity.inputsystem/CHANGELOG.md
@@ -30,13 +30,17 @@ however, it has to be formatted properly to pass verification tests.
 - Fixed tooltip support in the UI Toolkit version of the Input Actions Asset editor.
 - Fixed documentation to clarify bindings with modifiers `overrideModifiersNeedToBePressedFirst` configuration [ISXB-806](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-806).
 - Fixed an issue in `Samples/Visualizers/GamepadVisualizer.unity` sample where the visualization wouldn't handle device disconnects or current device changes properly (ISXB-1243).
+- Fixed an issue when displaying Serialized InputAction's Processor properties inside the Inspector window. [ISXB-1269](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1269)
 
 ### Changed
 - Added back the InputManager to InputSystem project-wide asset migration code with performance improvement (ISX-2086).
 - Changed `OnScreenControl` to automaticaly switch, in Single Player with autoswitch enabled, to the target device control scheme when the first component is enabled to prevent bad interactions when it start.
 - Changed paremeter `overrideModifiersNeedToBePressedFirst` to obsolete for `ButtonWithOneModifier`, `ButtonWithTwoModifiers`, `OneModifierComposite` and `TwoModifiersComposite` in favour the new `modifiersOrder` parameter which is more explicit.
 - Changed `Samples/Visualizers/GamepadVisualizer.unity` to visualize the control values of the current device instead of the first device.
 
+### Added
+- Added new API `InputSystem.settings.useIMGUIEditorForAssets` that should be used in custom `InputParameterEditor` that use both IMGUI and UI Toolkit.
+
 ## [1.11.2] - 2024-10-16
 
 ### Fixed
diff --git a/Packages/com.unity.inputsystem/InputSystem/Actions/Composites/AxisComposite.cs b/Packages/com.unity.inputsystem/InputSystem/Actions/Composites/AxisComposite.cs
@@ -220,7 +220,7 @@ internal class AxisCompositeEditor : InputParameterEditor<AxisComposite>
         public override void OnGUI()
         {
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;
+            if (!InputSystem.settings.useIMGUIEditorForAssets) return;
 #endif
             target.whichSideWins = (AxisComposite.WhichSideWins)EditorGUILayout.EnumPopup(m_WhichAxisWinsLabel, target.whichSideWins);
         }
diff --git a/Packages/com.unity.inputsystem/InputSystem/Actions/Composites/Vector2Composite.cs b/Packages/com.unity.inputsystem/InputSystem/Actions/Composites/Vector2Composite.cs
@@ -200,7 +200,7 @@ internal class Vector2CompositeEditor : InputParameterEditor<Vector2Composite>
         public override void OnGUI()
         {
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;
+            if (!InputSystem.settings.useIMGUIEditorForAssets) return;
 #endif
             target.mode = (Vector2Composite.Mode)EditorGUILayout.EnumPopup(m_ModeLabel, target.mode);
         }
diff --git a/Packages/com.unity.inputsystem/InputSystem/Actions/Composites/Vector3Composite.cs b/Packages/com.unity.inputsystem/InputSystem/Actions/Composites/Vector3Composite.cs
@@ -180,7 +180,7 @@ internal class Vector3CompositeEditor : InputParameterEditor<Vector3Composite>
         public override void OnGUI()
         {
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;
+            if (!InputSystem.settings.useIMGUIEditorForAssets) return;
 #endif
             target.mode = (Vector3Composite.Mode)EditorGUILayout.EnumPopup(m_ModeLabel, target.mode);
         }
diff --git a/Packages/com.unity.inputsystem/InputSystem/Actions/Interactions/HoldInteraction.cs b/Packages/com.unity.inputsystem/InputSystem/Actions/Interactions/HoldInteraction.cs
@@ -125,7 +125,7 @@ protected override void OnEnable()
         public override void OnGUI()
         {
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;
+            if (!InputSystem.settings.useIMGUIEditorForAssets) return;
 #endif
             m_PressPointSetting.OnGUI();
             m_DurationSetting.OnGUI();
diff --git a/Packages/com.unity.inputsystem/InputSystem/Actions/Interactions/MultiTapInteraction.cs b/Packages/com.unity.inputsystem/InputSystem/Actions/Interactions/MultiTapInteraction.cs
@@ -197,7 +197,7 @@ protected override void OnEnable()
         public override void OnGUI()
         {
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;
+            if (!InputSystem.settings.useIMGUIEditorForAssets) return;
 #endif
             target.tapCount = EditorGUILayout.IntField(m_TapCountLabel, target.tapCount);
             m_TapDelaySetting.OnGUI();
diff --git a/Packages/com.unity.inputsystem/InputSystem/Actions/Interactions/PressInteraction.cs b/Packages/com.unity.inputsystem/InputSystem/Actions/Interactions/PressInteraction.cs
@@ -214,7 +214,7 @@ protected override void OnEnable()
         public override void OnGUI()
         {
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;
+            if (!InputSystem.settings.useIMGUIEditorForAssets) return;
 #endif
             EditorGUILayout.HelpBox(s_HelpBoxText);
             target.behavior = (PressBehavior)EditorGUILayout.EnumPopup(s_PressBehaviorLabel, target.behavior);
diff --git a/Packages/com.unity.inputsystem/InputSystem/Actions/Interactions/SlowTapInteraction.cs b/Packages/com.unity.inputsystem/InputSystem/Actions/Interactions/SlowTapInteraction.cs
@@ -89,7 +89,7 @@ protected override void OnEnable()
         public override void OnGUI()
         {
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;
+            if (!InputSystem.settings.useIMGUIEditorForAssets) return;
 #endif
             m_DurationSetting.OnGUI();
             m_PressPointSetting.OnGUI();
diff --git a/Packages/com.unity.inputsystem/InputSystem/Actions/Interactions/TapInteraction.cs b/Packages/com.unity.inputsystem/InputSystem/Actions/Interactions/TapInteraction.cs
@@ -103,7 +103,7 @@ protected override void OnEnable()
         public override void OnGUI()
         {
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;
+            if (!InputSystem.settings.useIMGUIEditorForAssets) return;
 #endif
             m_DurationSetting.OnGUI();
             m_PressPointSetting.OnGUI();
diff --git a/Packages/com.unity.inputsystem/InputSystem/Controls/Processors/AxisDeadzoneProcessor.cs b/Packages/com.unity.inputsystem/InputSystem/Controls/Processors/AxisDeadzoneProcessor.cs
@@ -94,7 +94,7 @@ protected override void OnEnable()
         public override void OnGUI()
         {
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;
+            if (!InputSystem.settings.useIMGUIEditorForAssets) return;
 #endif
             m_MinSetting.OnGUI();
             m_MaxSetting.OnGUI();
diff --git a/Packages/com.unity.inputsystem/InputSystem/Controls/Processors/StickDeadzoneProcessor.cs b/Packages/com.unity.inputsystem/InputSystem/Controls/Processors/StickDeadzoneProcessor.cs
@@ -83,7 +83,7 @@ protected override void OnEnable()
         public override void OnGUI()
         {
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;
+            if (!InputSystem.settings.useIMGUIEditorForAssets) return;
 #endif
             m_MinSetting.OnGUI();
             m_MaxSetting.OnGUI();
diff --git a/Packages/com.unity.inputsystem/InputSystem/Editor/AssetEditor/InputActionEditorWindow.cs b/Packages/com.unity.inputsystem/InputSystem/Editor/AssetEditor/InputActionEditorWindow.cs
@@ -45,7 +45,7 @@ static InputActionEditorWindow()
         public static bool OnOpenAsset(int instanceId, int line)
         {
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets))
+            if (!InputSystem.settings.useIMGUIEditorForAssets)
                 return false;
 #endif
             var path = AssetDatabase.GetAssetPath(instanceId);
diff --git a/Packages/com.unity.inputsystem/InputSystem/Editor/AssetEditor/ParameterListView.cs b/Packages/com.unity.inputsystem/InputSystem/Editor/AssetEditor/ParameterListView.cs
@@ -353,7 +353,7 @@ public void OnGUI()
 
 #if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
             // handled by OnDrawVisualElements with UI Toolkit
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;
+            if (!InputSystem.settings.useIMGUIEditorForAssets) return;
 #endif
             // Otherwise, fall back to our default logic.
             if (m_Parameters == null)
diff --git a/Packages/com.unity.inputsystem/InputSystem/Editor/AssetImporter/InputActionImporterEditor.cs b/Packages/com.unity.inputsystem/InputSystem/Editor/AssetImporter/InputActionImporterEditor.cs
@@ -150,7 +150,7 @@ private static void OpenEditor(InputActionAsset asset)
             }
 
             // Redirect to UI-Toolkit window editor if not configured to use IMGUI explicitly
-            if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets))
+            if (!InputSystem.settings.useIMGUIEditorForAssets)
                 InputActionsEditorWindow.OpenEditor(asset);
             else
                 InputActionEditorWindow.OpenEditor(asset);
diff --git a/Packages/com.unity.inputsystem/InputSystem/Editor/PropertyDrawers/InputActionDrawerBase.cs b/Packages/com.unity.inputsystem/InputSystem/Editor/PropertyDrawers/InputActionDrawerBase.cs
@@ -180,9 +180,12 @@ public static void Show(Rect btnRect, PropertiesViewBase view)
                 window.ShowAsDropDown(btnRect, new Vector2(300, 350));
             }
 
+            private Vector2 m_ScrollPos;
             private void OnGUI()
             {
+                m_ScrollPos = EditorGUILayout.BeginScrollView(m_ScrollPos);
                 m_PropertyView.OnGUI();
+                EditorGUILayout.EndScrollView();
             }
 
             private PropertiesViewBase m_PropertyView;
diff --git a/Packages/com.unity.inputsystem/InputSystem/InputSettings.cs b/Packages/com.unity.inputsystem/InputSystem/InputSettings.cs
@@ -978,6 +978,17 @@ public enum InputActionPropertyDrawerMode
             MultilineBoth,
         }
 
+#if UNITY_EDITOR && UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
+        /// <summary>
+        /// Determines if we should render the UI with IMGUI even if an UI Toolkit UI is available.
+        ///
+        /// This should be used when writing a custom <see cref="InputParameterEditor"/> to :
+        /// * support inspector view which only work in IMGUI for now.
+        /// * prevent the UI to be rendered in IMGUI and UI Toolkit in the Input Actions Editor window.
+        /// </summary>
+        public bool useIMGUIEditorForAssets => UnityEditor.EditorGUI.indentLevel > 0 || IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets);
+#endif
+
         private static bool CompareFloats(float a, float b)
         {
             return (a - b) <= float.Epsilon;

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ internal class AxisCompositeEditor : InputParameterEditor<AxisComposite>`
`220`	`220`	`public override void OnGUI()`
`221`	`221`	`{`
`222`	`222`	`#if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS`
`223`		`- if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;`
	`223`	`+ if (!InputSystem.settings.useIMGUIEditorForAssets) return;`
`224`	`224`	`#endif`
`225`	`225`	`target.whichSideWins = (AxisComposite.WhichSideWins)EditorGUILayout.EnumPopup(m_WhichAxisWinsLabel, target.whichSideWins);`
`226`	`226`	`}`
Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ internal class Vector2CompositeEditor : InputParameterEditor<Vector2Composite>`
`200`	`200`	`public override void OnGUI()`
`201`	`201`	`{`
`202`	`202`	`#if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS`
`203`		`- if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;`
	`203`	`+ if (!InputSystem.settings.useIMGUIEditorForAssets) return;`
`204`	`204`	`#endif`
`205`	`205`	`target.mode = (Vector2Composite.Mode)EditorGUILayout.EnumPopup(m_ModeLabel, target.mode);`
`206`	`206`	`}`
Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ internal class Vector3CompositeEditor : InputParameterEditor<Vector3Composite>`
`180`	`180`	`public override void OnGUI()`
`181`	`181`	`{`
`182`	`182`	`#if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS`
`183`		`- if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;`
	`183`	`+ if (!InputSystem.settings.useIMGUIEditorForAssets) return;`
`184`	`184`	`#endif`
`185`	`185`	`target.mode = (Vector3Composite.Mode)EditorGUILayout.EnumPopup(m_ModeLabel, target.mode);`
`186`	`186`	`}`
Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ protected override void OnEnable()`
`125`	`125`	`public override void OnGUI()`
`126`	`126`	`{`
`127`	`127`	`#if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS`
`128`		`- if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;`
	`128`	`+ if (!InputSystem.settings.useIMGUIEditorForAssets) return;`
`129`	`129`	`#endif`
`130`	`130`	`m_PressPointSetting.OnGUI();`
`131`	`131`	`m_DurationSetting.OnGUI();`
Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ protected override void OnEnable()`
`197`	`197`	`public override void OnGUI()`
`198`	`198`	`{`
`199`	`199`	`#if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS`
`200`		`- if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;`
	`200`	`+ if (!InputSystem.settings.useIMGUIEditorForAssets) return;`
`201`	`201`	`#endif`
`202`	`202`	`target.tapCount = EditorGUILayout.IntField(m_TapCountLabel, target.tapCount);`
`203`	`203`	`m_TapDelaySetting.OnGUI();`
Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ protected override void OnEnable()`
`214`	`214`	`public override void OnGUI()`
`215`	`215`	`{`
`216`	`216`	`#if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS`
`217`		`- if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;`
	`217`	`+ if (!InputSystem.settings.useIMGUIEditorForAssets) return;`
`218`	`218`	`#endif`
`219`	`219`	`EditorGUILayout.HelpBox(s_HelpBoxText);`
`220`	`220`	`target.behavior = (PressBehavior)EditorGUILayout.EnumPopup(s_PressBehaviorLabel, target.behavior);`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ protected override void OnEnable()`
`89`	`89`	`public override void OnGUI()`
`90`	`90`	`{`
`91`	`91`	`#if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS`
`92`		`- if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;`
	`92`	`+ if (!InputSystem.settings.useIMGUIEditorForAssets) return;`
`93`	`93`	`#endif`
`94`	`94`	`m_DurationSetting.OnGUI();`
`95`	`95`	`m_PressPointSetting.OnGUI();`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ protected override void OnEnable()`
`103`	`103`	`public override void OnGUI()`
`104`	`104`	`{`
`105`	`105`	`#if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS`
`106`		`- if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;`
	`106`	`+ if (!InputSystem.settings.useIMGUIEditorForAssets) return;`
`107`	`107`	`#endif`
`108`	`108`	`m_DurationSetting.OnGUI();`
`109`	`109`	`m_PressPointSetting.OnGUI();`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ protected override void OnEnable()`
`94`	`94`	`public override void OnGUI()`
`95`	`95`	`{`
`96`	`96`	`#if UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS`
`97`		`- if (!InputSystem.settings.IsFeatureEnabled(InputFeatureNames.kUseIMGUIEditorForAssets)) return;`
	`97`	`+ if (!InputSystem.settings.useIMGUIEditorForAssets) return;`
`98`	`98`	`#endif`
`99`	`99`	`m_MinSetting.OnGUI();`
`100`	`100`	`m_MaxSetting.OnGUI();`