FIX: reenable editor tests after changes to mock dialogues (ISX-1896) (#1894)

* reenabled tests
* added one new test to cover basic version of naming duplication that was missing

Author: stefanunity

Assets/Tests/InputSystem.Editor/ControlSchemeEditorTests.cs

@@ -197,7 +197,6 @@ public void WhenControlSchemeIsSelected_SelectedControlSchemeIndexIsSet()
 
     [Test]
     [Category("AssetEditor")]
-    [Ignore("Instability ISX-1905")]
     public void WhenControlSchemeIsSelected_SelectedControlSchemeIsPopulatedWithSelection()
     {
         var asset = TestData.inputActionAsset
@@ -260,9 +259,29 @@ public void DuplicateControlSchemeCommand_CreatesCopyOfControlSchemeWithUniqueNa
         Assert.That(newState.selectedControlScheme.deviceRequirements, Is.EqualTo(state.selectedControlScheme.deviceRequirements));
     }
 
+    [Test(Description = "Verifies that when duplicating Control Scheme ending on an Int it increments that Int and jumps already existing Int names")]
+    [Category("AssetEditor")]
+    public void DuplicateControlSchemeCommand_CreatesCopyOfControlSchemeWithUniqueNameEndingOnIntJumpsExistingNumbers()
+    {
+        var asset = TestData.inputActionAsset.Generate();
+
+        asset.AddControlScheme(new InputControlScheme(("Test")));
+        asset.AddControlScheme(new InputControlScheme(("Test1")));
+
+        //select "Test" Control Scheme
+        var state = TestData.EditorStateWithAsset(asset).Generate().With(selectedControlScheme: asset.controlSchemes[0]);
+
+        state.serializedObject.Update();
+
+        //duplicate "Test"
+        var newState = ControlSchemeCommands.DuplicateSelectedControlScheme()(in state);
+
+        //duplicated Control Scheme should be names "Test2", skipping "Test1"
+        Assert.That(newState.selectedControlScheme.name, Is.EqualTo("Test2"));
+    }
+
     [Test]
     [Category("AssetEditor")]
-    [Ignore("Disabled: This should not be called in batch mode.")]
     public void DeleteControlSchemeCommand_DeletesSelectedControlScheme()
     {
         var asset = TestData.inputActionAsset.WithControlScheme(TestData.controlScheme.WithOptionalDevice()).Generate();
@@ -284,7 +303,6 @@ public void DeleteControlSchemeCommand_DeletesSelectedControlScheme()
     [TestCase(3, 2, 1, "Test1")]
     [TestCase(1, 0, -1, null)]
     [Category("AssetEditor")]
-    [Ignore("Disabled: This should not be called in batch mode.")]
     public void DeleteControlSchemeCommand_SelectsAnotherControlSchemeAfterDelete(
         int controlSchemeCount,
         int selectedControlSchemeIndex,