FIX: NullReferenceException from Path dropdown. (#1887)

graham-huws · stefanunity · web-flow · commit 13d2764db649 · 2024-03-14T19:01:01.000+01:00
* FIX: NullReferenceException from Path dropdown.

---------

Co-authored-by: Stefan Schubert &lt;stefan@unity3d.com&gt;
Co-authored-by: StefanUnity &lt;40492087+stefanunity@users.noreply.github.com&gt;
diff --git a/Packages/com.unity.inputsystem/CHANGELOG.md b/Packages/com.unity.inputsystem/CHANGELOG.md
@@ -8,7 +8,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 Due to package verification, the latest version below is the unpublished version and the date is meaningless.
 however, it has to be formatted properly to pass verification tests.
 
-## [Unreleased] - YYYY-MM-DD
+## [1.8.1] - 2024-03-14
+
+### Fixed
+- NullReferenceException thrown when editing a binding path in InputActionAsset windows.
 
 ## [1.8.0] - 2024-03-12
 
diff --git a/Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/InputActionsEditorSettingsProvider.cs b/Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/InputActionsEditorSettingsProvider.cs
@@ -112,6 +112,9 @@ void SaveAssetOnFocusLost()
 
         public static void SetIMGUIDropdownVisible(bool visible, bool optionWasSelected)
         {
+            if (m_ActiveSettingsProvider == null)
+                return;
+
             // If we selected an item from the dropdown, we *should* still be focused on this settings window - but
             // since the IMGUI dropdown is technically a separate window, we have to refocus manually.
             //

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,9 @@ void SaveAssetOnFocusLost()`
`112`	`112`
`113`	`113`	`public static void SetIMGUIDropdownVisible(bool visible, bool optionWasSelected)`
`114`	`114`	`{`
	`115`	`+ if (m_ActiveSettingsProvider == null)`
	`116`	`+ return;`
	`117`	`+`
`115`	`118`	`// If we selected an item from the dropdown, we should still be focused on this settings window - but`
`116`	`119`	`// since the IMGUI dropdown is technically a separate window, we have to refocus manually.`
`117`	`120`	`//`