Skip to content

Commit f1e51f4

Browse files
committed
move to latest Buffer typings, make Buffer <-> ArrayBuffer converters return objects sharing memory with the original
1 parent 599d5ca commit f1e51f4

2 files changed

Lines changed: 9 additions & 17 deletions

File tree

src/arraybuffers/arraybuffers.ts

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -121,24 +121,16 @@ export function stringToUtf8EncodedArrayBuffer(str:string) :ArrayBuffer {
121121
return ab.buffer;
122122
}
123123

124-
// Converts a node.js Buffer to an ArrayBuffer
125-
export function bufferToArrayBuffer(buffer:Buffer) :ArrayBuffer {
126-
var ab = new ArrayBuffer(buffer.length);
127-
var bytes = new Uint8Array(ab);
128-
for (var i = 0; i < buffer.length; ++i) {
129-
bytes[i] = buffer[i];
130-
}
131-
return bytes.buffer;
124+
// Returns an ArrayBuffer backed by the same memory as the supplied
125+
// Node.js Buffer.
126+
export function bufferToArrayBuffer(buffer: Buffer): ArrayBuffer {
127+
return buffer.buffer;
132128
}
133129

134-
// Converts an ArrayBuffer to a node.js Buffer
135-
export function arrayBufferToBuffer(ab:ArrayBuffer) :Buffer {
136-
var buffer = new Buffer(ab.byteLength);
137-
var bytes = new Uint8Array(ab);
138-
for (var i = 0; i < buffer.length; ++i) {
139-
buffer[i] = bytes[i];
140-
}
141-
return buffer;
130+
// Returns a Node.js Buffer backed by the same memory as the supplied
131+
// ArrayBuffer.
132+
export function arrayBufferToBuffer(ab: ArrayBuffer): Buffer {
133+
return new Buffer(ab);
142134
}
143135

144136
// Splits an ArrayBuffer into two at a given offset

third_party/typings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"es6-promise": "registry:dt/es6-promise#0.0.0+20160317120654",
88
"freedom": "registry:dt/freedom#0.6.26+20160317120654",
99
"jasmine": "registry:dt/jasmine#2.2.0+20160317120654",
10-
"node": "registry:dt/node#4.0.0+20160330064709",
10+
"node": "registry:dt/node#4.0.0+20160412142033",
1111
"ssh2": "registry:dt/ssh2#0.0.0+20160316155526"
1212
}
1313
}

0 commit comments

Comments
 (0)