Merge pull request #84 from SergeyGulik/task_completion_hangs

TaskCompletionSource may hang an application when used with async/await.

Author: PatrickRitchie

libraries/MTConnect.NET-HTTP/Ceen/Common/AppDomainTask.cs

@@ -11,7 +11,7 @@ internal class AppDomainTask : MarshalByRefObject
 		/// <summary>
 		/// A task completion source
 		/// </summary>
-		private TaskCompletionSource<object> m_tcs = new TaskCompletionSource<object>();
+		private TaskCompletionSource<object> m_tcs = new TaskCompletionSource<object>(TaskCreationOptions.RunContinuationsAsynchronously);
 
 		/// <summary>
 		/// Marks the operation complete

libraries/MTConnect.NET-HTTP/Ceen/Common/AsyncLock.cs

@@ -48,9 +48,7 @@ public AsyncSemaphore(int initialCount)
 		{
 			if (token.IsCancellationRequested)
 			{
-				var tcs = new TaskCompletionSource<bool>();
-				tcs.SetCanceled();
-				return tcs.Task;
+				return Task.FromCanceled(token);
 			}
 
 			lock (m_waiters)
@@ -62,7 +60,7 @@ public AsyncSemaphore(int initialCount)
 				}
 				else
 				{
-					var waiter = new TaskCompletionSource<bool>();
+					var waiter = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
 
 					// Make sure the waiter returns asap on cancellation
 					var registrar =

libraries/MTConnect.NET-HTTP/Ceen/Httpd/Handler/FileMirrorHandler.cs

@@ -175,7 +175,7 @@ public override async Task<bool> HandleAsync(IHttpContext context, CancellationT
                     if (!m_activeTransfers.TryGetValue(localpath, out task))
                     {
                         m_activeTransferSizes[localpath] = -1;
-                        m_activeTransfers[localpath] = task = (tcs = new TaskCompletionSource<long>()).Task;
+                        m_activeTransfers[localpath] = task = (tcs = new TaskCompletionSource<long>(TaskCreationOptions.RunContinuationsAsynchronously)).Task;
                     }
                 }
 
@@ -518,7 +518,7 @@ private async Task DownloadRemoteFileAsync(IHttpContext context, string localpat
                             // Swap around and notify of the progress
                             var oldsignal = signal;
                             lock (m_statuslock)
-                                m_activeTransfers[localpath] = (signal = new TaskCompletionSource<long>()).Task;
+                                m_activeTransfers[localpath] = (signal = new TaskCompletionSource<long>(TaskCreationOptions.RunContinuationsAsynchronously)).Task;
                             oldsignal.TrySetResult(pg);
                         }
                     }

libraries/MTConnect.NET-HTTP/Ceen/Httpd/HttpServer.cs

@@ -280,15 +280,15 @@ private class RunnerControl
 			/// <summary>
 			/// The task used to signal all requests are stopped
 			/// </summary>
-			private readonly TaskCompletionSource<bool> m_finishedtask = new TaskCompletionSource<bool>();
+			private readonly TaskCompletionSource<bool> m_finishedtask = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
 			/// <summary>
 			/// The task used to signal all handlers to stop
 			/// </summary>
-			private readonly TaskCompletionSource<bool> m_stoptask = new TaskCompletionSource<bool>();
+			private readonly TaskCompletionSource<bool> m_stoptask = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
 			/// <summary>
 			/// The task used to signal waiting for handlers to complete before starting new handlers
 			/// </summary>
-			private TaskCompletionSource<bool> m_throttletask = new TaskCompletionSource<bool>();
+			private TaskCompletionSource<bool> m_throttletask = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
 
 			/// <summary>
 			/// A logger for reporting the internal log state
@@ -338,7 +338,7 @@ public bool RegisterActive(string logtaskid)
 					if (m_debuglogger != null) m_debuglogger("Blocking throttle", logtaskid, null);
 					lock (m_lock)
 						if (m_throttletask.Task.IsCompleted)
-							m_throttletask = new TaskCompletionSource<bool>();
+							m_throttletask = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
 				}
 
 				return true;
@@ -986,7 +986,7 @@ private static async Task Runner(Stream stream, EndPoint endpoint, string logtas
                         // Set up call context access to this instance
                         Context.SetCurrentContext(context);
 
-                        var timeoutcontroltask = new TaskCompletionSource<bool>();
+                        var timeoutcontroltask = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
                         var idletime = TimeSpan.FromSeconds(config.RequestHeaderReadTimeoutSeconds);
 
                         // Set up timeout for processing