Skip to content

Commit b819809

Browse files
Merge pull request #81 from SergeyGulik/test_fix
Fixed tests compilation.
2 parents 816844d + 6966a6b commit b819809

3 files changed

Lines changed: 24 additions & 20 deletions

File tree

tests/IntegrationTests/ClientAgentCommunicationTests.cs

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -67,21 +67,6 @@ public ClientAgentCommunicationTests(
6767
//_machineName = $"Machine{_fixture.CurrentAgentPort}";
6868

6969
var devicesFile = "devices.xml";
70-
71-
var configuration = new ShdrAgentConfiguration
72-
{
73-
Port = _fixture.CurrentAgentPort,
74-
Adapters = new List<ShdrAdapterClientConfiguration>()
75-
{
76-
new()
77-
{
78-
DeviceKey = _machineName,
79-
Hostname = "localhost",
80-
Port = _fixture.CurrentAdapterPort
81-
}
82-
}
83-
};
84-
8570
GenerateDevicesXml(
8671
_machineId,
8772
_machineName,
@@ -93,10 +78,20 @@ public ClientAgentCommunicationTests(
9378

9479
AddCuttingTools();
9580

96-
_agent = new MTConnectAgentBroker(configuration);
81+
_agent = new MTConnectAgentBroker();
9782
//_agent.Version = new Version(1, 8);
9883
_agent.Start();
9984

85+
var adapters = new List<ShdrAdapterClientConfiguration>()
86+
{
87+
new()
88+
{
89+
DeviceKey = _machineName,
90+
Hostname = "localhost",
91+
Port = _fixture.CurrentAdapterPort
92+
}
93+
};
94+
10095
// Add Adapter Clients
10196
var devices = DeviceConfiguration.FromFile(devicesFile, DocumentFormat.XML).ToList();
10297
if (!devices.IsNullOrEmpty())
@@ -107,7 +102,7 @@ public ClientAgentCommunicationTests(
107102
_agent.AddDevice(device);
108103
}
109104

110-
foreach (var adapterConfiguration in configuration.Adapters)
105+
foreach (var adapterConfiguration in adapters)
111106
{
112107
var device = devices.FirstOrDefault(o => o.Name == adapterConfiguration.DeviceKey);
113108
if (device != null)
@@ -119,6 +114,10 @@ public ClientAgentCommunicationTests(
119114
}
120115
}
121116

117+
var configuration = new HttpServerConfiguration
118+
{
119+
Port = _fixture.CurrentAgentPort
120+
};
122121
_server = new MTConnectHttpServer(configuration, _agent);
123122
_server.Start();
124123
}

tests/MTConnect.NET-XML-Tests/Streams/Current.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
using System.IO;
66
using System.Linq;
77
using System.Text;
8+
using System.Xml;
89

910
namespace MTConnect.Tests.XML.Streams
1011
{
@@ -19,9 +20,10 @@ public void ReadStreamTestFiles()
1920
{
2021
foreach (var file in files)
2122
{
22-
var originalBytes = File.ReadAllBytes(file);
23+
using var fileStream = File.OpenRead(file);
24+
using var xmlReader = XmlReader.Create(fileStream);
2325

24-
var doc = XmlStreamsResponseDocument.FromXml(originalBytes);
26+
var doc = XmlStreamsResponseDocument.ReadXml(xmlReader);
2527

2628
Assert.That(doc != null, $"Read Original : {file}");
2729
}

tests/MTConnect.NET-XML-Tests/XmlStreamsResponseDocumentTests.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
using System;
2+
using System.IO;
23
using System.Linq;
34
using System.Text;
5+
using System.Xml;
46
using DeepEqual.Syntax;
57
using MTConnect.Observations;
68
using MTConnect.Streams.Xml;
@@ -28,7 +30,8 @@ public void TwoConditionsShouldBeParsed()
2830
</Streams>
2931
</MTConnectStreams>";
3032

31-
var doc = XmlStreamsResponseDocument.FromXml(Encoding.UTF8.GetBytes(text));
33+
using var xmlStream = XmlReader.Create(new MemoryStream(Encoding.UTF8.GetBytes(text)));
34+
var doc = XmlStreamsResponseDocument.ReadXml(xmlStream);
3235

3336
Assert.AreEqual(1, doc.Streams.Count());
3437
var stream = doc.Streams.Single();

0 commit comments

Comments
 (0)