Skip to content
This repository was archived by the owner on Mar 2, 2022. It is now read-only.

Commit 97f93b6

Browse files
authored
Merge pull request #89 from TheTorProject/nn_revert_remove_hashing_readbody
Revert "Remove hashingReadBody because unit tests fail with this" tests not passing in travis are unrelated to these changes
2 parents cd023b2 + 0509ab5 commit 97f93b6

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

bwscanner/measurement.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,11 @@
44
from stem.descriptor.networkstatus import RouterStatusEntryV3
55

66
from twisted.internet import defer
7-
from twisted.web.client import readBody
87

98
from bwscanner.logger import log
109
from bwscanner.attacher import SOCKSClientStreamAttacher
1110
from bwscanner.circuit import TwoHop
12-
from bwscanner.fetcher import OnionRoutedAgent
11+
from bwscanner.fetcher import OnionRoutedAgent, hashingReadBody
1312
from bwscanner.writer import ResultSink
1413

1514
# defer.setDebugging(True)
@@ -112,12 +111,13 @@ def fetch(self, path):
112111
log.info("Downloading file '{file_size}' over [{relay_fp}, {exit_fp}].",
113112
file_size=url.split('/')[-1], relay_fp=path[0].id_hex, exit_fp=path[-1].id_hex)
114113
file_size = self.choose_file_size(path) # File size in MB
114+
file_hash = self.bw_files[file_size][1]
115115
time_start = self.now()
116116

117117
@defer.inlineCallbacks
118118
def get_circuit_bw(result):
119119
time_end = self.now()
120-
if len(result) != file_size * 1024:
120+
if result != file_hash:
121121
raise DownloadIncomplete
122122
report = dict()
123123
report['time_end'] = time_end
@@ -164,7 +164,7 @@ def gotResult(result):
164164

165165
agent = OnionRoutedAgent(self.clock, path=path, state=self.state)
166166
request = agent.request("GET", url)
167-
request.addCallback(readBody)
167+
request.addCallback(hashingReadBody) # returns a readBody Deferred
168168
timeoutDeferred(request, self.request_timeout)
169169
request.addCallbacks(get_circuit_bw)
170170
request.addErrback(circ_failure)

0 commit comments

Comments
 (0)