Add Microsoft.CodeAnalysis.FxCopAnalyzers and fix warnings

inyutin-maxim · inyutin-maxim · commit d6e4396aad23 · 2019-04-18T21:36:05.000+03:00
diff --git a/System.IO.Abstractions.Analyzers/Analyzers/BaseFileSystemNodeAnalyzer.cs b/System.IO.Abstractions.Analyzers/Analyzers/BaseFileSystemNodeAnalyzer.cs
@@ -48,6 +48,6 @@ protected override void AnalyzeCompilation(CompilationStartAnalysisContext compi
 
 		private bool IsStaticInvocationStartWith(InvocationExpressionSyntax invocation) => invocation.Expression.NormalizeWhitespace()
 			.ToFullString()
-			.StartsWith(GetFileSystemType().Name + ".");
+			.StartsWith(GetFileSystemType().Name + ".", StringComparison.InvariantCultureIgnoreCase);
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers/RoslynToken/RoslynClassFileSystem.cs b/System.IO.Abstractions.Analyzers/RoslynToken/RoslynClassFileSystem.cs
@@ -49,7 +49,7 @@ public static UsingDirectiveSyntax GetSystemIoUsing(CompilationUnitSyntax unit)
 		public static UsingDirectiveSyntax GetUsing(CompilationUnitSyntax unit, string usingName)
 		{
 			return unit.Usings.FirstOrDefault(x =>
-				x.Name.NormalizeWhitespace().ToFullString().Equals(usingName));
+				x.Name.NormalizeWhitespace().ToFullString().Equals(usingName, StringComparison.InvariantCultureIgnoreCase));
 		}
 
 		public static FieldDeclarationSyntax CreateFileSystemFieldDeclaration()
diff --git a/System.IO.Abstractions.Analyzers/System.IO.Abstractions.Analyzers.csproj b/System.IO.Abstractions.Analyzers/System.IO.Abstractions.Analyzers.csproj
@@ -36,12 +36,13 @@
 	</PropertyGroup>
 	<ItemGroup>
 		<PackageReference Include="JetBrains.Annotations" Version="2019.1.1" PrivateAssets="all" />
-		<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="2.9.1" PrivateAssets="all" />
+		<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="2.9.2" PrivateAssets="all" />
 		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.0.0" PrivateAssets="all" />
 		<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.0.0" PrivateAssets="all" />
 		<PackageReference Update="NETStandard.Library" PrivateAssets="all" />
-		<PackageReference Include="Microsoft.CodeQuality.Analyzers" Version="2.9.1" PrivateAssets="all" />
-		<PackageReference Include="Roslyn.Diagnostics.Analyzers" Version="2.9.1" PrivateAssets="all" />
+		<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.2" PrivateAssets="all" />
+		<PackageReference Include="Microsoft.CodeQuality.Analyzers" Version="2.9.2" PrivateAssets="all" />
+		<PackageReference Include="Roslyn.Diagnostics.Analyzers" Version="2.9.2" PrivateAssets="all" />
 	</ItemGroup>
 	<ItemGroup>
 		<None Update="tools\*.ps1" CopyToOutputDirectory="Always" Pack="true" PackagePath="" />

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,6 @@ protected override void AnalyzeCompilation(CompilationStartAnalysisContext compi`
`48`	`48`
`49`	`49`	`private bool IsStaticInvocationStartWith(InvocationExpressionSyntax invocation) => invocation.Expression.NormalizeWhitespace()`
`50`	`50`	`.ToFullString()`
`51`		`- .StartsWith(GetFileSystemType().Name + ".");`
	`51`	`+ .StartsWith(GetFileSystemType().Name + ".", StringComparison.InvariantCultureIgnoreCase);`
`52`	`52`	`}`
`53`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public static UsingDirectiveSyntax GetSystemIoUsing(CompilationUnitSyntax unit)`
`49`	`49`	`public static UsingDirectiveSyntax GetUsing(CompilationUnitSyntax unit, string usingName)`
`50`	`50`	`{`
`51`	`51`	`return unit.Usings.FirstOrDefault(x =>`
`52`		`- x.Name.NormalizeWhitespace().ToFullString().Equals(usingName));`
	`52`	`+ x.Name.NormalizeWhitespace().ToFullString().Equals(usingName, StringComparison.InvariantCultureIgnoreCase));`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`public static FieldDeclarationSyntax CreateFileSystemFieldDeclaration()`