Use Operations instead of SyntaxNodes for analysis (#177)

Author: FantasyTeddy

System.IO.Abstractions.Analyzers.Tests/Analyzers/DirectoryInfoAnalyzerTests.cs

@@ -21,7 +21,6 @@ public void Analyzer_is_not_triggered(string filename)
 
 	[Theory]
 	[InlineData("WithOutFileSystem.txt", 15, 28)]
-	[InlineData("StaticInvocation.txt", 15, 40)]
 	public void Analyzer_is_triggered(string filename, int diagnosticLine, int diagnosticColumn)
 	{
 		var source = ReadFile(filename);

System.IO.Abstractions.Analyzers.Tests/Analyzers/PathAnalyzerTests.cs

@@ -13,6 +13,7 @@ public class PathAnalyzerTests : CSharpDiagnosticAnalyzerTest<PathAnalyzer>
 	[InlineData("Valid.txt")]
 	[InlineData("UsingStaticFalsePositive.txt")]
 	[InlineData("UsingStaticLinqFalsePositive.txt")]
+	[InlineData("NonRelatedFieldFalsePositive.txt")]
 	public void Analyzer_is_not_triggered(string filename)
 	{
 		var source = ReadFile(filename);

System.IO.Abstractions.Analyzers.Tests/TestData/Analyzer/DirectoryAnalyzer/WithOutFileSystem.txt

@@ -12,7 +12,7 @@ namespace SomeNameSpace
 		{
 			const string path = "C:\\temp";
 
-			Directory.Remove(path);
+			Directory.Delete(path);
 		}
 	}
 }

System.IO.Abstractions.Analyzers.Tests/TestData/Analyzer/DirectoryInfoAnalyzer/StaticInvocation.txt

@@ -0,0 +1,12 @@
+namespace SomeNameSpace
+{
+	public class NonRelatedFieldFalsePositive
+	{
+		private const string Path = "Some/Path/To/Something";
+
+		public string SomeMethod()
+		{
+			return Path.Replace('/', '_');
+		}
+	}
+}

System.IO.Abstractions.Analyzers.Tests/TestData/Analyzer/PathAnalyzer/NonRelatedFieldFalsePositive.txt

@@ -1,3 +1,4 @@
+using System.IO;
 using System.IO.Abstractions;
 
 namespace SomeNameSpace
@@ -15,7 +16,9 @@ namespace SomeNameSpace
 		{
 			const string filePath = "C:\\temp";
 
-			new ConfigurationBuilder().SetBasePath(_fileSystem.Directory.GetCurrentDirectory());
+			SetBasePath(_fileSystem.Directory.GetCurrentDirectory());
 		}
+
+		private void SetBasePath(string path) {}
 	}
 }

System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/DirectoryCodeFix/AfterFix.txt

@@ -1,3 +1,4 @@
+using System.IO;
 using System.IO.Abstractions;
 
 namespace SomeNameSpace
@@ -15,7 +16,9 @@ namespace SomeNameSpace
 		{
 			const string filePath = "C:\\temp";
 
-			new ConfigurationBuilder().SetBasePath(Directory.GetCurrentDirectory());
+			SetBasePath(Directory.GetCurrentDirectory());
 		}
+
+		private void SetBasePath(string path) {}
 	}
 }

System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/DirectoryCodeFix/BeforeFix.txt

@@ -1,3 +1,4 @@
+using System.IO;
 using System.IO.Abstractions;
 
 namespace SomeNameSpace
@@ -15,7 +16,7 @@ namespace SomeNameSpace
 		{
 			const string filePath = "C:\\temp.txt";
 
-			DirectoryInfo dirInfo = _fileSystem.DirectoryInfo.FromDirectoryName(filePath);
+			var dirInfo = _fileSystem.DirectoryInfo.New(filePath);
 		}
 	}
 }

System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/DirectoryInfoCodeFix/AfterFix.txt

@@ -1,3 +1,4 @@
+using System.IO;
 using System.IO.Abstractions;
 
 namespace SomeNameSpace
@@ -15,7 +16,7 @@ namespace SomeNameSpace
 		{
 			const string filePath = "C:\\temp.txt";
 
-			DirectoryInfo dirInfo = new DirectoryInfo(filePath);
+			var dirInfo = new DirectoryInfo(filePath);
 		}
 	}
 }

System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/DirectoryInfoCodeFix/BeforeFix.txt

@@ -1,3 +1,4 @@
+using System.IO;
 using System.IO.Abstractions;
 
 namespace SomeNameSpace