Merge pull request #723 from pjonsson/update-eslint

Update to ESLint 8.57.1

Author: na9da

.eslintrc

@@ -0,0 +1,5 @@
+"use strict";
+
+module.exports = {
+  extends: "./node_modules/terriajs/.eslintrc.js"
+};

.eslintrc.js

@@ -22,4 +22,4 @@ jobs:
       - run: rm -rf node_modules && yarn install --frozen-lockfile
       - run: yarn gulp lint release
         env:
-          NODE_OPTIONS: '--max_old_space_size=4096'
+          NODE_OPTIONS: "--max_old_space_size=4096"

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ To get in touch:
 
 ## Major announcements
 
-Following is a list of major announcements and upgrades that may affect users maintaining a fork (copied from [TerriaJS announcements](https://github.com/TerriaJS/terriajs/discussions/categories/announcements)). For a full list of changes to TerriaMap, including the latest versions of TerriaJS included with each release please refer to [CHANGES.md](https://github.com/TerriaJS/TerriaMap/blob/main/CHANGES.md). 
+Following is a list of major announcements and upgrades that may affect users maintaining a fork (copied from [TerriaJS announcements](https://github.com/TerriaJS/terriajs/discussions/categories/announcements)). For a full list of changes to TerriaMap, including the latest versions of TerriaJS included with each release please refer to [CHANGES.md](https://github.com/TerriaJS/TerriaMap/blob/main/CHANGES.md).
 
 ### We have released TerriaJS v8.3.0 (2023-05-22)
 

README.md

@@ -186,12 +186,9 @@ gulp.task(
 
 gulp.task("lint", function (done) {
   var runExternalModule = require("terriajs/buildprocess/runExternalModule");
-
-  runExternalModule("eslint/bin/eslint.js", [
-    "-c",
-    path.join(getPackageRoot("terriajs"), ".eslintrc.js"),
-    "--ignore-pattern",
-    "lib/ThirdParty",
+  const eslintDir = path.dirname(require.resolve("eslint/package.json"));
+  const eslintExecutable = path.join(eslintDir, "bin", "eslint.js");
+  runExternalModule(eslintExecutable, [
     "--max-warnings",
     "0",
     "index.js",

gulpfile.js

@@ -44,15 +44,15 @@
   "devDependencies": {
     "@babel/core": "^7.23.5",
     "@babel/eslint-parser": "^7.23.3",
+    "@babel/plugin-syntax-dynamic-import": "^7.8.3",
     "@babel/preset-env": "^7.23.5",
     "@babel/preset-react": "^7.23.3",
-    "@babel/plugin-syntax-dynamic-import": "^7.8.3",
     "@typescript-eslint/eslint-plugin": "^6.12.0",
     "@typescript-eslint/parser": "^6.12.0",
     "babel-loader": "^8.2.3",
     "css-loader": "^2.1.0",
     "ejs": "^3.1.10",
-    "eslint": "^7.20.0",
+    "eslint": "^8.57.1",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-react": "^7.19.0",
     "eslint-plugin-react-hooks": "^4.6.0",