Merge pull request #648 from TerriaJS/sass-upgrade

Replace `node-sass` with (dart) `sass`

Author: nf-s

.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x, 16.x]
+        node-version: [16.x, 18.x, 20.x]
 
     steps:
       - uses: actions/checkout@v2
@@ -22,4 +22,5 @@ jobs:
       - run: rm -rf node_modules && yarn install --frozen-lockfile
       - run: yarn gulp lint release
         env:
-          NODE_OPTIONS: --max_old_space_size=4096
+          # We need to use --openssl-legacy-provider for node 18.x and node 20.x
+          NODE_OPTIONS: ${{ matrix.node-version != '16.x' && '--max_old_space_size=4096 --openssl-legacy-provider' || '--max_old_space_size=4096'}}

.gitignore

@@ -28,3 +28,4 @@ yarn-error.log
 .npmrc
 
 package-lock.json
+.nvmrc

CHANGES.md

@@ -2,6 +2,8 @@
 
 ### The Next Release
 
+- Updated TerriaJS to `8.4.x`.
+- Replaced `node-sass` with `sass`. ("both packages expose the same JavaScript API", so no changes should be required)
 - [The next improvement]
 
 ### `0.0.9`

package.json

@@ -60,7 +60,6 @@
     "json5": "^2.1.0",
     "minimist": "^1.2.8",
     "node-notifier": "^5.1.2",
-    "node-sass": "^6.0.1",
     "plugin-error": "^1.0.1",
     "prettier": "2.7.1",
     "pretty-quick": "^1.10.0",
@@ -70,11 +69,12 @@
     "react-dom": "^16.14.0",
     "redbox-react": "^1.3.6",
     "resolve-url-loader": "^3.0.1",
+    "sass": "^1.66.1",
     "sass-loader": "^10",
     "semver": "^5.0.0",
     "style-loader": "^0.23.1",
     "svg-sprite-loader": "4.1.3",
-    "terriajs": "8.3.9",
+    "terriajs": "8.4.0",
     "terriajs-cesium": "1.92.0-tile-error-provider-fix-2",
     "ts-loader": "^5.3.3",
     "typescript": "^4.9.5",