Skip to content

Commit ea18b4e

Browse files
committed
Move import export manager to separate folder
1 parent 5e7ad6f commit ea18b4e

3 files changed

Lines changed: 19 additions & 16 deletions

File tree

app/src/main/java/org/schabi/newpipe/settings/BackupRestoreSettingsFragment.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import org.schabi.newpipe.NewPipeDatabase;
2525
import org.schabi.newpipe.R;
2626
import org.schabi.newpipe.error.ErrorUtil;
27+
import org.schabi.newpipe.settings.export.ImportExportManager;
2728
import org.schabi.newpipe.streams.io.NoFileManagerSafeGuard;
2829
import org.schabi.newpipe.streams.io.StoredFileHelper;
2930
import org.schabi.newpipe.util.NavigationHelper;
@@ -42,7 +43,7 @@ public class BackupRestoreSettingsFragment extends BasePreferenceFragment {
4243

4344
private final SimpleDateFormat exportDateFormat =
4445
new SimpleDateFormat("yyyyMMdd_HHmmss", Locale.US);
45-
private ContentSettingsManager manager;
46+
private ImportExportManager manager;
4647
private String importExportDataPathKey;
4748
private final ActivityResultLauncher<Intent> requestImportPathLauncher =
4849
registerForActivityResult(new ActivityResultContracts.StartActivityForResult(),
@@ -57,7 +58,7 @@ public void onCreatePreferences(@Nullable final Bundle savedInstanceState,
5758
@Nullable final String rootKey) {
5859
final File homeDir = ContextCompat.getDataDir(requireContext());
5960
Objects.requireNonNull(homeDir);
60-
manager = new ContentSettingsManager(new NewPipeFileLocator(homeDir));
61+
manager = new ImportExportManager(new NewPipeFileLocator(homeDir));
6162
manager.deleteSettingsFile();
6263

6364
importExportDataPathKey = getString(R.string.import_export_data_path);

app/src/main/java/org/schabi/newpipe/settings/ContentSettingsManager.kt renamed to app/src/main/java/org/schabi/newpipe/settings/export/ImportExportManager.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
package org.schabi.newpipe.settings
1+
package org.schabi.newpipe.settings.export
22

33
import android.content.SharedPreferences
44
import android.util.Log
55
import org.schabi.newpipe.MainActivity.DEBUG
6+
import org.schabi.newpipe.settings.NewPipeFileLocator
67
import org.schabi.newpipe.streams.io.SharpOutputStream
78
import org.schabi.newpipe.streams.io.StoredFileHelper
89
import org.schabi.newpipe.util.ZipHelper
@@ -11,7 +12,7 @@ import java.io.ObjectInputStream
1112
import java.io.ObjectOutputStream
1213
import java.util.zip.ZipOutputStream
1314

14-
class ContentSettingsManager(private val fileLocator: NewPipeFileLocator) {
15+
class ImportExportManager(private val fileLocator: NewPipeFileLocator) {
1516
companion object {
1617
const val TAG = "ContentSetManager"
1718
}

app/src/test/java/org/schabi/newpipe/settings/ContentSettingsManagerTest.kt renamed to app/src/test/java/org/schabi/newpipe/settings/ImportExportManagerTest.kt

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import org.mockito.Mockito.verify
1717
import org.mockito.Mockito.`when`
1818
import org.mockito.Mockito.withSettings
1919
import org.mockito.junit.MockitoJUnitRunner
20+
import org.schabi.newpipe.settings.export.ImportExportManager
2021
import org.schabi.newpipe.streams.io.StoredFileHelper
2122
import us.shandian.giga.io.FileStream
2223
import java.io.File
@@ -25,10 +26,10 @@ import java.nio.file.Files
2526
import java.util.zip.ZipFile
2627

2728
@RunWith(MockitoJUnitRunner::class)
28-
class ContentSettingsManagerTest {
29+
class ImportExportManagerTest {
2930

3031
companion object {
31-
private val classloader = ContentSettingsManager::class.java.classLoader!!
32+
private val classloader = ImportExportManager::class.java.classLoader!!
3233
}
3334

3435
private lateinit var fileLocator: NewPipeFileLocator
@@ -54,7 +55,7 @@ class ContentSettingsManagerTest {
5455

5556
val output = File.createTempFile("newpipe_", "")
5657
`when`(storedFileHelper.stream).thenReturn(FileStream(output))
57-
ContentSettingsManager(fileLocator).exportDatabase(sharedPreferences, storedFileHelper)
58+
ImportExportManager(fileLocator).exportDatabase(sharedPreferences, storedFileHelper)
5859

5960
val zipFile = ZipFile(output)
6061
val entries = zipFile.entries().toList()
@@ -77,7 +78,7 @@ class ContentSettingsManagerTest {
7778
val settings = File.createTempFile("newpipe_", "")
7879
`when`(fileLocator.settings).thenReturn(settings)
7980

80-
ContentSettingsManager(fileLocator).deleteSettingsFile()
81+
ImportExportManager(fileLocator).deleteSettingsFile()
8182

8283
assertFalse(settings.exists())
8384
}
@@ -87,7 +88,7 @@ class ContentSettingsManagerTest {
8788
val settings = File("non_existent")
8889
`when`(fileLocator.settings).thenReturn(settings)
8990

90-
ContentSettingsManager(fileLocator).deleteSettingsFile()
91+
ImportExportManager(fileLocator).deleteSettingsFile()
9192

9293
assertFalse(settings.exists())
9394
}
@@ -98,7 +99,7 @@ class ContentSettingsManagerTest {
9899
Assume.assumeTrue(dir.delete())
99100
`when`(fileLocator.dbDir).thenReturn(dir)
100101

101-
ContentSettingsManager(fileLocator).ensureDbDirectoryExists()
102+
ImportExportManager(fileLocator).ensureDbDirectoryExists()
102103
assertTrue(dir.exists())
103104
}
104105

@@ -107,7 +108,7 @@ class ContentSettingsManagerTest {
107108
val dir = Files.createTempDirectory("newpipe_").toFile()
108109
`when`(fileLocator.dbDir).thenReturn(dir)
109110

110-
ContentSettingsManager(fileLocator).ensureDbDirectoryExists()
111+
ImportExportManager(fileLocator).ensureDbDirectoryExists()
111112
assertTrue(dir.exists())
112113
}
113114

@@ -124,7 +125,7 @@ class ContentSettingsManagerTest {
124125

125126
val zip = File(classloader.getResource("settings/newpipe.zip")?.file!!)
126127
`when`(storedFileHelper.stream).thenReturn(FileStream(zip))
127-
val success = ContentSettingsManager(fileLocator).extractDb(storedFileHelper)
128+
val success = ImportExportManager(fileLocator).extractDb(storedFileHelper)
128129

129130
assertTrue(success)
130131
assertFalse(dbJournal.exists())
@@ -143,7 +144,7 @@ class ContentSettingsManagerTest {
143144

144145
val emptyZip = File(classloader.getResource("settings/empty.zip")?.file!!)
145146
`when`(storedFileHelper.stream).thenReturn(FileStream(emptyZip))
146-
val success = ContentSettingsManager(fileLocator).extractDb(storedFileHelper)
147+
val success = ImportExportManager(fileLocator).extractDb(storedFileHelper)
147148

148149
assertFalse(success)
149150
assertTrue(dbJournal.exists())
@@ -159,7 +160,7 @@ class ContentSettingsManagerTest {
159160

160161
val zip = File(classloader.getResource("settings/newpipe.zip")?.file!!)
161162
`when`(storedFileHelper.stream).thenReturn(FileStream(zip))
162-
val contains = ContentSettingsManager(fileLocator).extractSettings(storedFileHelper)
163+
val contains = ImportExportManager(fileLocator).extractSettings(storedFileHelper)
163164

164165
assertTrue(contains)
165166
}
@@ -171,7 +172,7 @@ class ContentSettingsManagerTest {
171172

172173
val emptyZip = File(classloader.getResource("settings/empty.zip")?.file!!)
173174
`when`(storedFileHelper.stream).thenReturn(FileStream(emptyZip))
174-
val contains = ContentSettingsManager(fileLocator).extractSettings(storedFileHelper)
175+
val contains = ImportExportManager(fileLocator).extractSettings(storedFileHelper)
175176

176177
assertFalse(contains)
177178
}
@@ -185,7 +186,7 @@ class ContentSettingsManagerTest {
185186
val editor = Mockito.mock(SharedPreferences.Editor::class.java)
186187
`when`(preferences.edit()).thenReturn(editor)
187188

188-
ContentSettingsManager(fileLocator).loadSharedPreferences(preferences)
189+
ImportExportManager(fileLocator).loadSharedPreferences(preferences)
189190

190191
verify(editor, atLeastOnce()).putBoolean(anyString(), anyBoolean())
191192
verify(editor, atLeastOnce()).putString(anyString(), anyString())

0 commit comments

Comments
 (0)