Merge pull request #9496 from Jared234/9437_continue_playing_while_seeking

Seeking no longer pauses the played video

Author: Stypox

app/src/main/java/org/schabi/newpipe/player/Player.java

@@ -216,7 +216,6 @@ public final class Player implements PlaybackListener, Listener {
     // minimized to background but will resume automatically to the original player type
     private boolean isAudioOnly = false;
     private boolean isPrepared = false;
-    private boolean wasPlaying = false;
 
     /*//////////////////////////////////////////////////////////////////////////
     // UIs, listeners and disposables
@@ -918,13 +917,6 @@ private Disposable getProgressUpdateDisposable() {
                         error -> Log.e(TAG, "Progress update failure: ", error));
     }
 
-    public void saveWasPlaying() {
-        this.wasPlaying = getPlayWhenReady();
-    }
-
-    public boolean wasPlaying() {
-        return wasPlaying;
-    }
     //endregion
 
 

app/src/main/java/org/schabi/newpipe/player/PlayerService.java

@@ -86,8 +86,6 @@ public void stopForImmediateReusing() {
         }
 
         if (!player.exoPlayerIsNull()) {
-            player.saveWasPlaying();
-
             // Releases wifi & cpu, disables keepScreenOn, etc.
             // We can't just pause the player here because it will make transition
             // from one stream to a new stream not smooth

app/src/main/java/org/schabi/newpipe/player/ui/VideoPlayerUi.java

@@ -618,11 +618,6 @@ public void onStartTrackingTouch(final SeekBar seekBar) {
             player.changeState(STATE_PAUSED_SEEK);
         }
 
-        player.saveWasPlaying();
-        if (player.isPlaying()) {
-            player.getExoPlayer().pause();
-        }
-
         showControls(0);
         animate(binding.currentDisplaySeek, true, DEFAULT_CONTROLS_DURATION,
                 AnimationType.SCALE_AND_ALPHA);
@@ -637,7 +632,7 @@ public void onStopTrackingTouch(final SeekBar seekBar) {
         }
 
         player.seekTo(seekBar.getProgress());
-        if (player.wasPlaying() || player.getExoPlayer().getDuration() == seekBar.getProgress()) {
+        if (player.getExoPlayer().getDuration() == seekBar.getProgress()) {
             player.getExoPlayer().play();
         }
 
@@ -651,9 +646,8 @@ public void onStopTrackingTouch(final SeekBar seekBar) {
         if (!player.isProgressLoopRunning()) {
             player.startProgressLoop();
         }
-        if (player.wasPlaying()) {
-            showControlsThenHide();
-        }
+
+        showControlsThenHide();
     }
     //endregion
 
@@ -1188,8 +1182,6 @@ private void onQualityClicked() {
             binding.qualityTextView.setText(MediaFormat.getNameById(videoStream.getFormatId())
                     + " " + videoStream.getResolution());
         }
-
-        player.saveWasPlaying();
     }
 
     /**