refactor(devtools): clean up imports and improve text handling in SEO tab components

This commit refactors the SEO tab components by cleaning up imports related to severity handling and ensuring consistent text handling by removing unnecessary nullish coalescing and optional chaining. These changes enhance code readability and maintainability across the heading structure, JSON-LD, and links preview components.

Author: abedshaaban

packages/devtools/src/tabs/seo-tab/heading-structure-preview.tsx

@@ -1,7 +1,8 @@
 import { For, Show } from 'solid-js'
 import { Section, SectionDescription } from '@tanstack/devtools-ui'
 import { useStyles } from '../../styles/use-styles'
-import { pickSeverityClass, type SeoSeverity } from './seo-severity'
+import { pickSeverityClass } from './seo-severity'
+import type { SeoSeverity } from './seo-severity'
 import type { SeoSectionSummary } from './seo-section-summary'
 
 type HeadingItem = {
@@ -29,7 +30,7 @@ function extractHeadings(): Array<HeadingItem> {
       id: node.id || `heading-${index}`,
       level,
       tag,
-      text: node.textContent?.trim() || '',
+      text: node.textContent.trim() || '',
     }
   })
 }

packages/devtools/src/tabs/seo-tab/json-ld-preview.tsx

@@ -1,11 +1,8 @@
 import { For, Show } from 'solid-js'
 import { Section, SectionDescription } from '@tanstack/devtools-ui'
 import { useStyles } from '../../styles/use-styles'
-import {
-  pickSeverityClass,
-  seoHealthTier,
-  type SeoSeverity,
-} from './seo-severity'
+import { pickSeverityClass, seoHealthTier } from './seo-severity'
+import type { SeoSeverity } from './seo-severity'
 import type { SeoSectionSummary } from './seo-section-summary'
 
 type JsonLdValue = Record<string, unknown>
@@ -269,7 +266,7 @@ function stringifyPreviewValue(value: unknown, maxLen = 200): string {
       return value.join(', ')
     }
     if (value.length === 1 && isRecord(value[0])) {
-      const o = value[0] as JsonLdValue
+      const o = value[0]
       const t = typeof o['@type'] === 'string' ? String(o['@type']) : 'Item'
       const label =
         typeof o.name === 'string'
@@ -330,7 +327,7 @@ function analyzeJsonLdScripts(): Array<JsonLdEntry> {
   )
 
   return scripts.map((script, index) => {
-    const raw = script.textContent?.trim() ?? ''
+    const raw = script.textContent.trim()
     if (!raw) {
       return {
         id: `jsonld-${index}`,
@@ -462,7 +459,7 @@ function getJsonLdScore(entries: Array<JsonLdEntry>): number {
     for (const issue of entry.issues) {
       if (issue.severity === 'error') errors += 1
       else if (issue.severity === 'warning') warnings += 1
-      else if (issue.severity === 'info') infos += 1
+      else infos += 1
     }
   }
 

packages/devtools/src/tabs/seo-tab/links-preview.tsx

@@ -1,7 +1,8 @@
 import { For, Show, createSignal } from 'solid-js'
 import { Section, SectionDescription } from '@tanstack/devtools-ui'
 import { useStyles } from '../../styles/use-styles'
-import { pickSeverityClass, type SeoSeverity } from './seo-severity'
+import { pickSeverityClass } from './seo-severity'
+import type { SeoSeverity } from './seo-severity'
 import type { SeoSectionSummary } from './seo-section-summary'
 
 type LinkKind = 'internal' | 'external' | 'non-web' | 'invalid'
@@ -22,7 +23,7 @@ type LinkRow = {
 function classifyLink(anchor: HTMLAnchorElement): LinkRow {
   const href = anchor.getAttribute('href')?.trim() || ''
   const text =
-    anchor.textContent?.trim() ||
+    anchor.textContent.trim() ||
     anchor.getAttribute('aria-label')?.trim() ||
     anchor.getAttribute('title')?.trim() ||
     ''

packages/devtools/src/tabs/seo-tab/seo-overview.tsx

@@ -8,19 +8,15 @@ import { getSerpPreviewSummary } from './serp-preview'
 import { getJsonLdPreviewSummary } from './json-ld-preview'
 import { getHeadingStructureSummary } from './heading-structure-preview'
 import { getLinksPreviewSummary } from './links-preview'
+import { pickSeverityClass, seoHealthTier } from './seo-severity'
 import {
   aggregateSeoHealth,
   countBySeverity,
   sectionHealthScore,
   worstSeverity,
-  type SeoDetailView,
-  type SeoSectionSummary,
 } from './seo-section-summary'
-import {
-  pickSeverityClass,
-  seoHealthTier,
-  type SeoSeverity,
-} from './seo-severity'
+import type { SeoSeverity } from './seo-severity'
+import type { SeoDetailView, SeoSectionSummary } from './seo-section-summary'
 
 type OverviewRow = {
   id: SeoDetailView