fix(ios): P2 HIG polish — search caps, structure refresh, filter confirm, badge contrast, iPad sidebar (#678)

Author: datlechin

TableProMobile/TableProMobile/Views/ConnectionListView.swift

@@ -9,6 +9,7 @@ import TableProSync
 
 struct ConnectionListView: View {
     @Environment(AppState.self) private var appState
+    @Environment(\.horizontalSizeClass) private var sizeClass
     @State private var showingAddConnection = false
     @State private var editingConnection: DatabaseConnection?
     @State private var selectedConnectionId: UUID?
@@ -132,6 +133,32 @@ struct ConnectionListView: View {
         }
     }
 
+    @ViewBuilder
+    private var connectionList: some View {
+        let list = List(selection: $selectedConnectionId) {
+            if groupByGroup {
+                groupedContent
+            } else {
+                ForEach(displayedConnections) { connection in
+                    connectionRow(connection)
+                }
+                .onMove { source, destination in
+                    var items = displayedConnections
+                    items.move(fromOffsets: source, toOffset: destination)
+                    for index in items.indices {
+                        items[index].sortOrder = index
+                    }
+                    appState.reorderConnections(items)
+                }
+            }
+        }
+        if sizeClass == .regular {
+            list.listStyle(.sidebar)
+        } else {
+            list.listStyle(.insetGrouped)
+        }
+    }
+
     @ViewBuilder
     private var sidebar: some View {
         if appState.connections.isEmpty && !isSyncing {
@@ -149,24 +176,7 @@ struct ConnectionListView: View {
             ProgressView("Syncing from iCloud...")
                 .frame(maxWidth: .infinity, maxHeight: .infinity)
         } else {
-            List(selection: $selectedConnectionId) {
-                if groupByGroup {
-                    groupedContent
-                } else {
-                    ForEach(displayedConnections) { connection in
-                        connectionRow(connection)
-                    }
-                    .onMove { source, destination in
-                        var items = displayedConnections
-                        items.move(fromOffsets: source, toOffset: destination)
-                        for index in items.indices {
-                            items[index].sortOrder = index
-                        }
-                        appState.reorderConnections(items)
-                    }
-                }
-            }
-            .listStyle(.insetGrouped)
+            connectionList
             .overlay {
                 if !appState.connections.isEmpty && displayedConnections.isEmpty {
                     ContentUnavailableView(
@@ -403,12 +413,12 @@ private struct ConnectionRow: View {
             if let tag {
                 Text(tag.name)
                     .font(.caption)
-                    .foregroundStyle(ConnectionColorPicker.swiftUIColor(for: tag.color))
+                    .foregroundStyle(.white)
                     .padding(.horizontal, 8)
                     .padding(.vertical, 3)
                     .background(
                         Capsule()
-                            .fill(ConnectionColorPicker.swiftUIColor(for: tag.color).opacity(0.15))
+                            .fill(ConnectionColorPicker.swiftUIColor(for: tag.color))
                     )
             }
         }

TableProMobile/TableProMobile/Views/DataBrowserView.swift

@@ -204,6 +204,7 @@ struct DataBrowserView: View {
                 .navigationTitle(table.name)
                 .navigationBarTitleDisplayMode(.inline)
                 .searchable(text: $searchText, prompt: "Search all columns")
+                .textInputAutocapitalization(.never)
                 .onSubmit(of: .search) { applySearch() }
                 .onChange(of: searchText) { oldValue, newValue in
                     if newValue.isEmpty, !oldValue.isEmpty, hasActiveSearch {
@@ -696,6 +697,7 @@ private struct FilterSheetView: View {
 
     @State private var draft: [TableFilter] = []
     @State private var draftLogicMode: FilterLogicMode = .and
+    @State private var showClearConfirmation = false
 
     private var hasValidFilters: Bool {
         draft.contains { $0.isEnabled && $0.isValid }
@@ -763,10 +765,7 @@ private struct FilterSheetView: View {
                 if !draft.isEmpty {
                     Section {
                         Button("Clear All Filters", role: .destructive) {
-                            filters.removeAll()
-                            logicMode = .and
-                            onClear()
-                            dismiss()
+                            showClearConfirmation = true
                         }
                     }
                 }
@@ -791,6 +790,20 @@ private struct FilterSheetView: View {
                 draft = filters
                 draftLogicMode = logicMode
             }
+            .confirmationDialog(
+                String(localized: "Clear All Filters"),
+                isPresented: $showClearConfirmation,
+                titleVisibility: .visible
+            ) {
+                Button(String(localized: "Clear All"), role: .destructive) {
+                    filters.removeAll()
+                    logicMode = .and
+                    onClear()
+                    dismiss()
+                }
+            } message: {
+                Text("All filter conditions will be removed.")
+            }
         }
     }
 }

TableProMobile/TableProMobile/Views/InsertRowView.swift

@@ -113,6 +113,7 @@ struct InsertRowView: View {
                     }
                 }
             }
+            .scrollDismissesKeyboard(.interactively)
             .formStyle(.grouped)
             .navigationTitle("Insert Row")
             .navigationBarTitleDisplayMode(.inline)

TableProMobile/TableProMobile/Views/RowDetailView.swift

@@ -100,7 +100,7 @@ struct RowDetailView: View {
                     .transition(.move(edge: .bottom).combined(with: .opacity))
             }
         }
-        .navigationTitle(String(format: String(localized: "Row %d of %d"), currentIndex + 1, rows.count))
+        .navigationTitle(table?.name ?? String(format: String(localized: "Row %d of %d"), currentIndex + 1, rows.count))
         .navigationBarTitleDisplayMode(.inline)
         .toolbar {
             ToolbarItem(placement: .topBarTrailing) {

TableProMobile/TableProMobile/Views/StructureView.swift

@@ -29,37 +29,39 @@ struct StructureView: View {
     @State private var appError: AppError?
 
     var body: some View {
-        VStack(spacing: 0) {
+        Group {
+            if isLoading {
+                ProgressView("Loading structure...")
+                    .frame(maxWidth: .infinity, maxHeight: .infinity)
+            } else if let appError {
+                ErrorView(error: appError) {
+                    await loadStructure()
+                }
+            } else {
+                switch selectedTab {
+                case .columns:
+                    columnsTab
+                case .indexes:
+                    indexesTab
+                case .foreignKeys:
+                    foreignKeysTab
+                }
+            }
+        }
+        .safeAreaInset(edge: .top) {
             Picker("Section", selection: $selectedTab) {
                 ForEach(Tab.allCases, id: \.self) { tab in
                     Text(tab.rawValue).tag(tab)
                 }
             }
             .pickerStyle(.segmented)
-            .padding()
-
-            Group {
-                if isLoading {
-                    ProgressView("Loading structure...")
-                        .frame(maxWidth: .infinity, maxHeight: .infinity)
-                } else if let appError {
-                    ErrorView(error: appError) {
-                        await loadStructure()
-                    }
-                } else {
-                    switch selectedTab {
-                    case .columns:
-                        columnsTab
-                    case .indexes:
-                        indexesTab
-                    case .foreignKeys:
-                        foreignKeysTab
-                    }
-                }
-            }
+            .padding(.horizontal)
+            .padding(.vertical, 8)
+            .background(.bar)
         }
         .navigationTitle(table.name)
         .navigationBarTitleDisplayMode(.inline)
+        .refreshable { await loadStructure() }
         .task { await loadStructure() }
     }
 

TableProMobile/TableProMobile/Views/TableListView.swift

@@ -101,6 +101,7 @@ struct TableListView: View {
         }
         .listStyle(.insetGrouped)
         .searchable(text: $searchText, prompt: "Search tables")
+        .textInputAutocapitalization(.never)
         .refreshable {
             await onRefresh?()
         }