fix: address review issues - skip double fetch, restore stale cleanup, fix error path

Author: datlechin

CHANGELOG.md

@@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Create Database dialog showing MySQL charset/collation options for all database types; now shows database-specific options (encoding/LC_COLLATE for PostgreSQL, hidden for Redis/etcd)
 - SSH Tunnel not working with `~/.ssh/config` profiles (#672): added `Include` directive support, SSH token expansion (`%d`, `%h`, `%u`, `%r`), multi-word `Host` filtering, and detailed handshake error messages
 
 ## [0.30.1] - 2026-04-10

TablePro/Views/Main/Extensions/MainContentCoordinator+Navigation.swift

@@ -423,7 +423,7 @@ extension MainContentCoordinator {
             await refreshTables()
         } catch {
             toolbarState.databaseName = previousDatabase
-            await refreshTables()
+            sidebarLoadingState = .error(error.localizedDescription)
 
             navigationLogger.error("Failed to switch database: \(error.localizedDescription, privacy: .public)")
             AlertHelper.showErrorSheet(

TablePro/Views/Main/MainContentCommandActions.swift

@@ -713,7 +713,9 @@ final class MainContentCommandActions {
             if let driver = DatabaseManager.shared.driver(for: self.connection.id) {
                 coordinator?.toolbarState.databaseVersion = driver.serverVersion
             }
-            await coordinator?.refreshTables()
+            if coordinator?.sidebarLoadingState != .loading {
+                await coordinator?.refreshTables()
+            }
             coordinator?.initRedisKeyTreeIfNeeded()
         }
     }

TablePro/Views/Main/MainContentCoordinator.swift

@@ -365,6 +365,30 @@ final class MainContentCoordinator {
             DatabaseManager.shared.updateSession(connectionId) { $0.tables = tables }
             let currentDb = DatabaseManager.shared.session(for: connectionId)?.activeDatabase
             await schemaProvider.resetForDatabase(currentDb, tables: tables, driver: driver)
+
+            // Clean up stale selections and pending operations for tables that no longer exist
+            if let vm = sidebarViewModel {
+                let validNames = Set(tables.map(\.name))
+                let staleSelections = vm.selectedTables.filter { !validNames.contains($0.name) }
+                if !staleSelections.isEmpty {
+                    vm.selectedTables.subtract(staleSelections)
+                }
+                let stalePendingDeletes = vm.pendingDeletes.subtracting(validNames)
+                if !stalePendingDeletes.isEmpty {
+                    vm.pendingDeletes.subtract(stalePendingDeletes)
+                    for name in stalePendingDeletes {
+                        vm.tableOperationOptions.removeValue(forKey: name)
+                    }
+                }
+                let stalePendingTruncates = vm.pendingTruncates.subtracting(validNames)
+                if !stalePendingTruncates.isEmpty {
+                    vm.pendingTruncates.subtract(stalePendingTruncates)
+                    for name in stalePendingTruncates {
+                        vm.tableOperationOptions.removeValue(forKey: name)
+                    }
+                }
+            }
+
             sidebarLoadingState = .loaded
         } catch {
             sidebarLoadingState = .error(error.localizedDescription)