chore: minor code quality improvements

- Convert DotNetCoreAssemblyResolver.AssemblyPath from public field to
  auto-property for better encapsulation
- Make FilterResult static fields readonly to prevent mutation
- Optimize MethodReference.BuildFullName with early return and
  StringBuilder instead of string concatenation via Aggregate

Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>

Author: alexanderlinne

ArchUnitNET/Loader/DotNetCoreAssemblyResolver.cs

@@ -12,7 +12,7 @@ internal class DotNetCoreAssemblyResolver : IAssemblyResolver
     {
         private readonly DefaultAssemblyResolver _defaultAssemblyResolver;
         private readonly Dictionary<string, AssemblyDefinition> _libraries;
-        public string AssemblyPath = "";
+        public string AssemblyPath { get; set; } = "";
 
         public DotNetCoreAssemblyResolver()
         {

ArchUnitNET/Loader/FilterResult.cs

@@ -16,22 +16,22 @@ public struct FilterResult
         /// <summary>
         /// Load this assembly and traverse its dependencies
         /// </summary>
-        public static FilterResult LoadAndContinue = new FilterResult(true, true);
+        public static readonly FilterResult LoadAndContinue = new FilterResult(true, true);
 
         /// <summary>
         /// Do not load this assembly, but traverse its dependencies
         /// </summary>
-        public static FilterResult SkipAndContinue = new FilterResult(true, false);
+        public static readonly FilterResult SkipAndContinue = new FilterResult(true, false);
 
         /// <summary>
         /// Load this assembly and do not traverse its dependencies
         /// </summary>
-        public static FilterResult LoadAndStop = new FilterResult(false, true);
+        public static readonly FilterResult LoadAndStop = new FilterResult(false, true);
 
         /// <summary>
         /// Do not load this assembly and do not traverse its dependencies
         /// </summary>
-        public static FilterResult DontLoadAndStop = new FilterResult(false, false);
+        public static readonly FilterResult DontLoadAndStop = new FilterResult(false, false);
 
         private FilterResult(bool traverseDependencies, bool loadThisAssembly)
         {

ArchUnitNET/Loader/MonoCecilMemberExtensions.cs

@@ -30,11 +30,18 @@ internal static class MonoCecilMemberExtensions
 
         internal static string BuildFullName(this MethodReference methodReference)
         {
-            return methodReference.FullName
-                + methodReference.GenericParameters.Aggregate(
-                    string.Empty,
-                    (current, newElement) => current + "<" + newElement.Name + ">"
-                );
+            if (!methodReference.HasGenericParameters)
+            {
+                return methodReference.FullName;
+            }
+
+            var sb = new StringBuilder(methodReference.FullName);
+            foreach (var p in methodReference.GenericParameters)
+            {
+                sb.Append('<').Append(p.Name).Append('>');
+            }
+
+            return sb.ToString();
         }
 
         [NotNull]