Skip to content

Commit eba48f6

Browse files
committed
fix(ui): Disable State and ER diagrams temporarily
**Problem:** State and ER diagrams have rendering issues and cause confusion. **Solution:** 1. Removed from system prompt (SystemPromptConfiguration.swift) - Deleted 'stateDiagram' and 'erDiagram' from Mermaid types list - LLMs will no longer be instructed to generate these types 2. Added parser guards (MermaidParser.swift) - Return .unsupported for state/ER diagrams - Log warning when encountered - Prevents attempted rendering **Impact:** - Test file mermaid-test.json will now show diagrams #3 (class) then #5 (gantt) with #4 (state) hidden - No more diagram numbering confusion - No more cross-diagram contamination **To Re-Enable:** 1. Fix rendering issues in StateDiagramRenderer.swift and ERDiagramRenderer.swift 2. Remove parser guards 3. Re-add to system prompt **Files Modified:** - Sources/ConfigurationSystem/SystemPromptConfiguration.swift (line 564) - Sources/UserInterface/Chat/Mermaid/MermaidParser.swift (lines 22-26) **Testing:** ✅ Build: PASS ⏳ User should no longer see State diagram (#4) ⏳ Class diagram should work correctly
1 parent 58d1448 commit eba48f6

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

Sources/ConfigurationSystem/SystemPromptConfiguration.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ private static func buildSAMSpecificPatterns() -> String {
561561
562562
## Data Visualization Protocol (CRITICAL)
563563
564-
**Mermaid Diagram Types:** flowchart, sequenceDiagram, classDiagram, stateDiagram, erDiagram, gantt, pie, barChart, journey, mindmap, timeline, quadrantChart, requirementDiagram, gitGraph, xychart-beta (bar/line charts).
564+
**Mermaid Diagram Types:** flowchart, sequenceDiagram, classDiagram, gantt, pie, barChart, journey, mindmap, timeline, quadrantChart, requirementDiagram, gitGraph, xychart-beta (bar/line charts).
565565
566566
**DECISION RULE - Mermaid vs Image Generation:**
567567

Sources/UserInterface/Chat/Mermaid/MermaidParser.swift

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,13 @@ struct MermaidParser {
2020
} else if trimmed.starts(with: "classDiagram") {
2121
return parseClassDiagram(trimmed)
2222
} else if trimmed.starts(with: "stateDiagram") {
23-
return parseStateDiagram(trimmed)
23+
// Temporarily disabled - rendering issues
24+
logger.warning("State diagrams temporarily disabled")
25+
return .unsupported(code)
2426
} else if trimmed.starts(with: "erDiagram") {
25-
return parseERDiagram(trimmed)
27+
// Temporarily disabled - rendering issues
28+
logger.warning("ER diagrams temporarily disabled")
29+
return .unsupported(code)
2630
} else if trimmed.starts(with: "gantt") {
2731
return parseGantt(trimmed)
2832
} else if trimmed.starts(with: "pie") {

0 commit comments

Comments
 (0)