Commit d46b93d
committed
docs(auth): remove remaining keychain references for API token
Problem: Commit 86634cd migrated samAPIToken from Keychain to UserDefaults,
but one code reference and multiple documentation references still mentioned
Keychain storage. This created inconsistency between implementation and docs,
and could cause runtime issues when trying to retrieve token from Keychain.
Root Cause: The migration was code-focused and didn't include a full sweep
of documentation and all code paths using the API token.
Solution: Completed the migration by updating all references:
- Fixed PreferencesView.swift to use UserDefaults instead of KeychainManager
- Updated all documentation to reflect UserDefaults storage pattern
- Maintained KeychainManager.swift itself (still used for other credentials)
Changes:
- PreferencesView.swift: Fixed token retrieval to use UserDefaults.standard
- API_AUTHENTICATION.md: Updated architecture section to reflect UserDefaults + caching
- README.md: Changed security descriptions to mention local storage, not Keychain
- API_INTEGRATION_SPECIFICATION.md: Updated code examples to show UserDefaults pattern
Testing:
✅ Build: PASS (make build-debug)
✅ Manual: Verified all changed files are documentation or UI code
✅ Edge cases: Confirmed KeychainManager still exists for other use cases
Impact: Completes the API token storage migration, ensuring code and
documentation are consistent. Users won't see keychain prompts for API
token access, improving UX as intended by original migration.1 parent 79a759a commit d46b93d
4 files changed
Lines changed: 15 additions & 15 deletions
File tree
- Sources/UserInterface
- project-docs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
245 | | - | |
| 245 | + | |
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1359 | 1359 | | |
1360 | 1360 | | |
1361 | 1361 | | |
1362 | | - | |
| 1362 | + | |
1363 | 1363 | | |
1364 | 1364 | | |
1365 | 1365 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
85 | | - | |
| 84 | + | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | 89 | | |
91 | | - | |
92 | 90 | | |
| 91 | + | |
93 | 92 | | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
900 | 900 | | |
901 | 901 | | |
902 | 902 | | |
903 | | - | |
| 903 | + | |
904 | 904 | | |
905 | | - | |
906 | | - | |
| 905 | + | |
| 906 | + | |
907 | 907 | | |
908 | 908 | | |
909 | | - | |
910 | | - | |
| 909 | + | |
| 910 | + | |
911 | 911 | | |
912 | 912 | | |
913 | | - | |
914 | | - | |
| 913 | + | |
| 914 | + | |
915 | 915 | | |
916 | 916 | | |
917 | 917 | | |
| |||
0 commit comments