Skip to content

fix friends freeze#763

Open
SharonStrats wants to merge 1 commit into
post-milestone3mfrom
fix/friend-card-loading
Open

fix friends freeze#763
SharonStrats wants to merge 1 commit into
post-milestone3mfrom
fix/friend-card-loading

Conversation

@SharonStrats
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new attachmentList option to control whether the widget registers a post-fetch callback to refresh rows once linked documents finish loading, and adds unit tests covering the default/on vs opt-out behavior.

Changes:

  • Added refreshOnDocumentLoad?: boolean to attachmentListOptions (defaulting to true) to allow callers to disable the document-load-driven refresh hook.
  • Updated attachmentList to gate fetcher.nowOrWhenFetched(...) registration behind refreshOnDocumentLoad.
  • Added unit tests asserting the default behavior and the opt-out behavior for the new option.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/widgets/buttons.ts Adds refreshOnDocumentLoad option and gates the nowOrWhenFetched refresh hook behind it.
test/unit/widgets/buttons.test.ts Adds tests covering the default refresh hook behavior and the opt-out flag; adds per-test cleanup for this suite.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/widgets/buttons.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants