Fix clippy warnings in baseline and HTTP parsing

Author: argahsuknesib

src/api/janus_api.rs

@@ -693,7 +693,7 @@ fn accumulate_bindings_into_baseline(
                 all_numeric: true,
             });
 
-            entry.last_value = normalized.clone();
+            entry.last_value.clone_from(&normalized);
             if let Ok(value) = normalized.parse::<f64>() {
                 entry.numeric_sum += value;
                 entry.numeric_count += 1;

src/http/server.rs

@@ -319,32 +319,15 @@ async fn get_query(
 
 fn parse_baseline_mode(raw: Option<&str>) -> Result<BaselineBootstrapMode, ApiError> {
     match raw {
-        None => Ok(BaselineBootstrapMode::Aggregate),
-        Some("aggregate") | Some("AGGREGATE") => Ok(BaselineBootstrapMode::Aggregate),
-        Some("last") | Some("LAST") => Ok(BaselineBootstrapMode::Last),
+        None | Some("aggregate" | "AGGREGATE") => Ok(BaselineBootstrapMode::Aggregate),
+        Some("last" | "LAST") => Ok(BaselineBootstrapMode::Last),
         Some(other) => Err(ApiError::BadRequest(format!(
             "Unsupported baseline_mode '{}'. Use 'aggregate' or 'last'",
             other
         ))),
     }
 }
 
-#[cfg(test)]
-mod tests {
-    use super::parse_baseline_mode;
-    use crate::registry::query_registry::BaselineBootstrapMode;
-
-    #[test]
-    fn test_parse_baseline_mode_defaults_to_aggregate() {
-        assert_eq!(parse_baseline_mode(None).unwrap(), BaselineBootstrapMode::Aggregate);
-    }
-
-    #[test]
-    fn test_parse_baseline_mode_accepts_last() {
-        assert_eq!(parse_baseline_mode(Some("last")).unwrap(), BaselineBootstrapMode::Last);
-    }
-}
-
 /// POST /api/queries/:id/start - Start executing a query
 async fn start_query(
     State(state): State<Arc<AppState>>,
@@ -664,3 +647,19 @@ pub async fn start_server(
 
     Ok(())
 }
+
+#[cfg(test)]
+mod tests {
+    use super::parse_baseline_mode;
+    use crate::registry::query_registry::BaselineBootstrapMode;
+
+    #[test]
+    fn test_parse_baseline_mode_defaults_to_aggregate() {
+        assert_eq!(parse_baseline_mode(None).unwrap(), BaselineBootstrapMode::Aggregate);
+    }
+
+    #[test]
+    fn test_parse_baseline_mode_accepts_last() {
+        assert_eq!(parse_baseline_mode(Some("last")).unwrap(), BaselineBootstrapMode::Last);
+    }
+}