Disable test in Windows

Author: jdalton

src/commands/manifest/convert_gradle_to_maven.ts

@@ -31,9 +31,11 @@ export async function convertGradleToMaven(
   }
 
   try {
-    // Run sbt with the init script we provide which should yield zero or more pom files.
-    // We have to figure out where to store those pom files such that we can upload them and predict them through the GitHub API.
-    // We could do a .socket folder. We could do a socket.pom.gz with all the poms, although I'd prefer something plain-text if it is to be committed.
+    // Run sbt with the init script we provide which should yield zero or more
+    // pom files. We have to figure out where to store those pom files such that
+    // we can upload them and predict them through the GitHub API. We could do a
+    // .socket folder. We could do a socket.pom.gz with all the poms, although
+    // I'd prefer something plain-text if it is to be committed.
 
     // Note: init.gradle will be exported by .config/rollup.dist.config.mjs
     const initLocation = path.join(constants.rootDistPath, 'init.gradle')

src/constants.ts

@@ -248,25 +248,17 @@ const lazyNmBinPath = () =>
   // Lazily access constants.rootPath.
   path.join(constants.rootPath, `${NODE_MODULES}/.bin`)
 
+// Harden Node security.
+// https://nodejs.org/en/learn/getting-started/security-best-practices
 const lazyNodeHardenFlags = () =>
   // The '@rollup/plugin-replace' will replace "process.env[INLINED_SOCKET_CLI_SENTRY_BUILD]".
   process.env[INLINED_SOCKET_CLI_SENTRY_BUILD]
     ? []
-    : // Harden Node security.
-      // https://nodejs.org/en/learn/getting-started/security-best-practices
-      [
-        '--disable-proto',
-        'delete',
-        // Lazily access constants.WIN32.
-        constants.WIN32
-          ? // We have contributed the following patches to our dependencies to make
-            // Node's --frozen-intrinsics workable.
-            // √ https://github.com/SBoudrias/Inquirer.js/pull/1683
-            // √ https://github.com/pnpm/components/pull/23
-            ['--frozen-intrinsics']
-          : [],
-        '--no-deprecation'
-      ]
+    : // We have contributed the following patches to our dependencies to make
+      // Node's --frozen-intrinsics workable.
+      // √ https://github.com/SBoudrias/Inquirer.js/pull/1683
+      // √ https://github.com/pnpm/components/pull/23
+      ['--disable-proto', 'delete', '--frozen-intrinsics', '--no-deprecation']
 
 const lazyRootBinPath = () =>
   // Lazily access constants.rootPath.

test/socket-cdxgen.test.ts

@@ -17,7 +17,11 @@ const testPath = __dirname
 const npmFixturesPath = path.join(testPath, 'socket-npm-fixtures')
 
 const spawnOpts: PromiseSpawnOptions = {
-  cwd: npmFixturesPath
+  cwd: npmFixturesPath,
+  env: {
+    ...process.env,
+    SOCKET_CLI_DEBUG: '1'
+  }
 }
 
 describe('Socket cdxgen command', async () => {
@@ -27,6 +31,7 @@ describe('Socket cdxgen command', async () => {
   it(
     'should forwards known commands to cdxgen',
     {
+      skip: process.platform === 'win32',
       // Takes ~10s in CI
       timeout: 20_000
     },