Fix alert-rules.test

Author: jdalton

.config/rollup.base.config.mjs

@@ -28,6 +28,8 @@ import {
   resolveId
 } from '../scripts/utils/packages.js'
 
+const require = createRequire(import.meta.url)
+
 const {
   BABEL_RUNTIME,
   LATEST,
@@ -41,46 +43,50 @@ const {
   tsconfigPath
 } = constants
 
-const require = createRequire(import.meta.url)
+const SOCKET_INTEROP = '_socketInterop'
 
-const tsPlugin = require('rollup-plugin-ts')
+const constantsSrcPath = path.join(rootSrcPath, 'constants.ts')
 
+const babelConfig = require(babelConfigPath)
+const tsPlugin = require('rollup-plugin-ts')
 const rootPackageJson = require(rootPackageJsonPath)
+
 const {
   dependencies: pkgDeps,
   devDependencies: pkgDevDeps,
   overrides: pkgOverrides
 } = rootPackageJson
 
-const SOCKET_INTEROP = '_socketInterop'
-
-const constantsSrcPath = path.join(rootSrcPath, 'constants.ts')
-
 const builtinAliases = builtinModules.reduce((o, n) => {
   o[n] = `node:${n}`
   return o
 }, {})
 
-const babelConfig = require(babelConfigPath)
-
 const customResolver = nodeResolve({
   exportConditions: ['node'],
   preferBuiltins: true
 })
 
 const requireAssignmentsRegExp =
   /(?<=\s*=\s*)require\(["'](?!node:|@socket(?:registry|security)\/|\.).+?["']\)(?=;?\r?\n)/g
+
 const checkRequireAssignmentRegExp = new RegExp(
   requireAssignmentsRegExp.source,
   ''
 )
 const checkSocketInteropUseRegExp = new RegExp(`\\b${SOCKET_INTEROP}\\b`)
+
 const danglingRequiresRegExp = /^\s*require\(["'].+?["']\);?\r?\n/gm
+
 const firstUseStrictRegExp = /'use strict';?/
+
 const oraSpinnersAssignmentsRegExp = /(?<=ora[^.]+\.spinners\s*=\s*)[$\w]+/g
+
 const requireTinyColorsRegExp = /require\(["']tiny-colors["']\)/g
+
 const requireUrlAssignmentRegExp =
   /(?<=var +)[$\w]+(?= *= *require\('node:url'\))/
+
 const splitUrlRequiresRegExp = /require\(["']u["']\s*\+\s*["']rl["']\)/g
 
 function isAncestorsExternal(id, depStats) {

.config/rollup.dist.config.mjs

@@ -12,6 +12,7 @@ import { isRelative } from '@socketsecurity/registry/lib/path'
 
 import baseConfig from './rollup.base.config.mjs'
 import constants from '../scripts/constants.js'
+import socketModifyPlugin from '../scripts/rollup/socket-modify-plugin.js'
 import { readJsonSync } from '../scripts/utils/fs.js'
 import { formatObject } from '../scripts/utils/objects.js'
 import {
@@ -38,6 +39,8 @@ const distRequirePath = path.join(rootDistPath, 'require')
 
 const editablePkgJson = readPackageJsonSync(rootPath, { editable: true })
 
+const processEnvTapRegExp = /\bprocess\.env(?:\.TAP|\[['"]TAP['"]\])(\s*\?[^:]+:\s*)?/g
+
 function removeDtsFilesSync(distPath) {
   for (const filepath of tinyGlobSync(['**/*.d.ts'], {
     absolute: true,
@@ -125,6 +128,12 @@ export default () => {
       return true
     },
     plugins: [
+      // When process.env['TAP'] is found either remove it, if part of a ternary
+      // operation, or replace it with `false`.
+      socketModifyPlugin({
+        find: processEnvTapRegExp,
+        replace: (match, ternary) => ternary ? '' : 'false'
+      }),
       {
         generateBundle(_options, bundle) {
           const constantsBundle = bundle[CONSTANTS_JS]

.config/rollup.test.config.mjs

@@ -18,10 +18,10 @@ const {
 
 export default () =>
   baseConfig({
-    input: {
-      misc: `${rootSrcPath}/utils/misc.ts`,
-      'path-resolve': `${rootSrcPath}/utils/path-resolve.ts`
-    },
+    input: ['alert-rules', 'misc', 'path-resolve'].reduce((o, k) => {
+      o[k] = `${rootSrcPath}/utils/${k}.ts`
+      return o
+    }, {}),
     output: [
       {
         dir: 'test/dist',

src/constants.ts

@@ -105,7 +105,9 @@ const lazyRootDistPath = () =>
   // Lazily access constants.rootPath.
   path.join(constants.rootPath, 'dist')
 
-const lazyRootPath = () => path.resolve(realpathSync(__dirname), '..')
+// The '@rollup/plugin-replace' will replace 'process.env.TAP' with `false` and
+// it will be dead code eliminated by Rollup.
+const lazyRootPath = () => path.resolve(realpathSync(__dirname), process.env['TAP'] ? '../..' : '..')
 
 const lazyRootPkgJsonPath = () =>
   // Lazily access constants.rootPath.

test/alert-rule-ux.test.ts test/alert-rules.test.tstest/alert-rule-ux.test.ts renamed to test/alert-rules.test.ts

@@ -1,7 +1,7 @@
 import assert from 'node:assert/strict'
 import { describe, it } from 'node:test'
 
-import { createAlertUXLookup } from '../src/utils/alert-rules'
+import { createAlertUXLookup } from './dist/alert-rules'
 
 describe('Alert Rule UX', () => {
   it('should properly defer', () => {