Skip to content

Commit 4fc4d66

Browse files
Respond to feedback
1 parent ae9ca4c commit 4fc4d66

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/ImageSharp/ColorProfiles/Icc/Calculators/LutABCalculator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ private void Init(IccTagDataEntry[] curveA, IccTagDataEntry[] curveB, IccTagData
127127

128128
Guard.IsTrue(
129129
hasACurve || hasBCurve || hasMCurve || hasMatrix || hasClut,
130-
nameof(curveB),
130+
"entry",
131131
"AToB or BToA tag must contain at least one processing element");
132132

133133
if (hasACurve)

src/ImageSharp/Metadata/Profiles/ICC/TagDataEntries/IccLutAToBTagDataEntry.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public bool Equals(IccLutAToBTagDataEntry other)
128128
&& this.OutputChannelCount == other.OutputChannelCount
129129
&& this.Matrix3x3.Equals(other.Matrix3x3)
130130
&& this.Matrix3x1.Equals(other.Matrix3x1)
131-
&& this.ClutValues.Equals(other.ClutValues)
131+
&& Equals(this.ClutValues, other.ClutValues)
132132
&& EqualsCurve(this.CurveB, other.CurveB)
133133
&& EqualsCurve(this.CurveM, other.CurveM)
134134
&& EqualsCurve(this.CurveA, other.CurveA);
@@ -168,7 +168,7 @@ private static bool EqualsCurve(IccTagDataEntry[] thisCurves, IccTagDataEntry[]
168168
return true;
169169
}
170170

171-
if (entryNull)
171+
if (thisNull || entryNull)
172172
{
173173
return false;
174174
}

src/ImageSharp/Metadata/Profiles/ICC/TagDataEntries/IccLutBToATagDataEntry.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public bool Equals(IccLutBToATagDataEntry other)
128128
&& this.OutputChannelCount == other.OutputChannelCount
129129
&& this.Matrix3x3.Equals(other.Matrix3x3)
130130
&& this.Matrix3x1.Equals(other.Matrix3x1)
131-
&& this.ClutValues.Equals(other.ClutValues)
131+
&& Equals(this.ClutValues, other.ClutValues)
132132
&& EqualsCurve(this.CurveB, other.CurveB)
133133
&& EqualsCurve(this.CurveM, other.CurveM)
134134
&& EqualsCurve(this.CurveA, other.CurveA);
@@ -167,7 +167,7 @@ private static bool EqualsCurve(IccTagDataEntry[] thisCurves, IccTagDataEntry[]
167167
return true;
168168
}
169169

170-
if (entryNull)
170+
if (thisNull || entryNull)
171171
{
172172
return false;
173173
}

0 commit comments

Comments
 (0)