Skip to content

Commit a9277df

Browse files
authored
Merge pull request #336 from Shopify/cbruckmayer/improve-error-message
Improve error message
2 parents 6eed81e + d25df63 commit a9277df

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

ruby/lib/minitest/queue/runner.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ def report_command
253253

254254
unless supervisor.wait_for_workers { display_warnings(supervisor.build) }
255255
unless supervisor.queue_initialized?
256-
abort! "No master was elected. Did all workers crash?", 40
256+
abort! "No leader was elected. This typically means no worker was able to start. Were there any errors during application boot?", 40
257257
end
258258

259259
unless supervisor.exhausted?

ruby/lib/rspec/queue.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ def call(options, stdout, stderr)
283283

284284
unless supervisor.wait_for_workers
285285
unless supervisor.queue_initialized?
286-
abort! "No master was elected. Did all workers crash?"
286+
abort! "No leader was elected. This typically means no worker was able to start. Were there any errors during application boot?"
287287
end
288288

289289
unless supervisor.exhausted?

ruby/test/integration/minitest_redis_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ def test_all_workers_died
269269
assert_empty err
270270
expected = <<~EXPECTED
271271
Waiting for workers to complete
272-
No master was elected. Did all workers crash?
272+
No leader was elected. This typically means no worker was able to start. Were there any errors during application boot?
273273
EXPECTED
274274
assert_equal expected.strip, normalize(out.lines[0..2].join.strip)
275275
end

0 commit comments

Comments
 (0)