Skip to content

Commit c9578a1

Browse files
committed
SVY-20819 use signals instead of @input in our components
use model<> instead of signal<>
1 parent 825665a commit c9578a1

7 files changed

Lines changed: 17 additions & 17 deletions

File tree

components/projects/bootstrapcomponents/src/calendar/basecalendar.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Renderer2, ChangeDetectorRef, Inject, Directive, SimpleChanges, DOCUMENT, input, output, signal } from '@angular/core';
1+
import { Renderer2, ChangeDetectorRef, Inject, Directive, SimpleChanges, DOCUMENT, input, output, model } from '@angular/core';
22
import { ServoyBootstrapBasefield } from '../bts_basefield';
33

44
import { getFirstDayOfWeek, LoggerService, ServoyPublicService } from '@servoy/public';
@@ -17,7 +17,7 @@ export class ServoyBootstrapBaseCalendar extends ServoyBootstrapBasefield<HTMLDi
1717
readonly maxDateChange = output();
1818
readonly minDate = input<Date>(undefined);
1919
readonly minDateChange = output();
20-
keepInvalid = signal<boolean>(undefined);
20+
keepInvalid = model<boolean>(undefined);
2121
readonly keepInvalidChange = output<boolean>();
2222

2323
readonly calendarWeeks = input<boolean>(undefined);

components/projects/bootstrapcomponents/src/floatlabelcalendar/floatlabelcalendar.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
import { Component, Renderer2, ChangeDetectorRef, ChangeDetectionStrategy, SimpleChanges, Inject, SimpleChange, DOCUMENT, input, output, signal } from '@angular/core';
2+
import { Component, Renderer2, ChangeDetectorRef, ChangeDetectionStrategy, SimpleChanges, Inject, SimpleChange, DOCUMENT, input, output, model } from '@angular/core';
33
import { FormattingService } from '@servoy/public';
44
import { LoggerFactory, ServoyPublicService, PopupStateService } from '@servoy/public';
55
import { ServoyBootstrapCalendar } from '../calendar/calendar';
@@ -14,7 +14,7 @@ export class ServoyFloatLabelBootstrapCalendar extends ServoyBootstrapCalendar {
1414

1515
readonly floatLabelText = input<string>(undefined);
1616
readonly errorMessage = input<string>(undefined);
17-
errorShow = signal<boolean>(undefined);
17+
errorShow = model<boolean>(undefined);
1818
readonly errorShowChange = output<boolean>();
1919

2020
constructor(renderer: Renderer2,

components/projects/bootstrapcomponents/src/floatlabelcombobox/floatlabelcombobox.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, Renderer2, SimpleChanges, ChangeDetectorRef, ViewChild, ViewChildren, QueryList, ElementRef, HostListener, ChangeDetectionStrategy, Inject, DOCUMENT, input, output, signal } from '@angular/core';
1+
import { Component, Renderer2, SimpleChanges, ChangeDetectorRef, ViewChild, ViewChildren, QueryList, ElementRef, HostListener, ChangeDetectionStrategy, Inject, DOCUMENT, input, output, model } from '@angular/core';
22
import { ServoyBootstrapCombobox } from '../combobox/combobox';
33
import { FormattingService, ServoyPublicService, PopupStateService} from '@servoy/public';
44

@@ -13,7 +13,7 @@ export class ServoyFloatLabelBootstrapCombobox extends ServoyBootstrapCombobox{
1313

1414
readonly floatLabelText = input<string>(undefined);
1515
readonly errorMessage = input<string>(undefined);
16-
errorShow = signal<boolean>(undefined);
16+
errorShow = model<boolean>(undefined);
1717
readonly errorShowChange = output<boolean>();
1818

1919
constructor(renderer: Renderer2, protected cdRef: ChangeDetectorRef, protected formatService: FormattingService,

components/projects/bootstrapcomponents/src/floatlabeltextarea/floatlabeltextarea.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
import { Component, ChangeDetectorRef, Renderer2, ChangeDetectionStrategy, Inject, SimpleChanges, SimpleChange, DOCUMENT, input, output, signal } from '@angular/core';
2+
import { Component, ChangeDetectorRef, Renderer2, ChangeDetectionStrategy, Inject, SimpleChanges, SimpleChange, DOCUMENT, input, output, model } from '@angular/core';
33
import { ServoyBootstrapTextarea } from '../textarea/textarea';
44

55
@Component({
@@ -12,7 +12,7 @@ export class ServoyFloatLabelBootstrapTextarea extends ServoyBootstrapTextarea {
1212

1313
readonly floatLabelText = input<string>(undefined);
1414
readonly errorMessage = input<string>(undefined);
15-
errorShow = signal<boolean>(undefined);
15+
errorShow = model<boolean>(undefined);
1616
readonly errorShowChange = output<boolean>();
1717

1818
constructor(renderer: Renderer2, cdRef: ChangeDetectorRef, @Inject(DOCUMENT) doc: Document) {

components/projects/bootstrapcomponents/src/floatlabeltextbox/floatlabeltextbox.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
import { Component, ChangeDetectorRef, Renderer2, ChangeDetectionStrategy, Inject, SimpleChanges, SimpleChange, DOCUMENT, input, output, signal } from '@angular/core';
2+
import { Component, ChangeDetectorRef, Renderer2, ChangeDetectionStrategy, Inject, SimpleChanges, SimpleChange, DOCUMENT, input, output, model } from '@angular/core';
33
import { WindowRefService } from '@servoy/public';
44
import { ServoyBootstrapTextbox } from '../textbox/textbox';
55

@@ -13,7 +13,7 @@ export class ServoyFloatLabelBootstrapTextbox extends ServoyBootstrapTextbox {
1313

1414
readonly floatLabelText = input<string>(undefined);
1515
readonly errorMessage = input<string>(undefined);
16-
errorShow = signal<boolean>(undefined);
16+
errorShow = model<boolean>(undefined);
1717
readonly errorShowChange = output<boolean>();
1818

1919
constructor(renderer: Renderer2, cdRef: ChangeDetectorRef, @Inject(DOCUMENT) doc: Document, protected windowService: WindowRefService) {

components/projects/bootstrapcomponents/src/floatlabeltypeahead/floatlabeltypeahead.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
import { Component, ChangeDetectorRef, Renderer2, ChangeDetectionStrategy, Inject, SimpleChanges, SimpleChange, DOCUMENT, input, output, signal } from '@angular/core';
2+
import { Component, ChangeDetectorRef, Renderer2, ChangeDetectionStrategy, Inject, SimpleChanges, SimpleChange, DOCUMENT, input, output, model } from '@angular/core';
33
import { WindowRefService, FormattingService, ServoyPublicService, PopupStateService} from '@servoy/public';
44
import { ServoyBootstrapTypeahead } from '../typeahead/typeahead';
55

@@ -13,7 +13,7 @@ export class ServoyFloatLabelBootstrapTypeahead extends ServoyBootstrapTypeahead
1313

1414
readonly floatLabelText = input<string>(undefined);
1515
readonly errorMessage = input<string>(undefined);
16-
errorShow = signal<boolean>(undefined);
16+
errorShow = model<boolean>(undefined);
1717
readonly errorShowChange = output<boolean>();
1818

1919
constructor(renderer: Renderer2, cdRef: ChangeDetectorRef, @Inject(DOCUMENT) doc: Document,

components/projects/bootstrapcomponents/src/tabpanel/tabpanel.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, Renderer2, SimpleChanges, ChangeDetectorRef, ChangeDetectionStrategy, ElementRef, AfterViewInit, OnDestroy, HostListener, input, output, viewChild, signal } from '@angular/core';
1+
import { Component, Renderer2, SimpleChanges, ChangeDetectorRef, ChangeDetectionStrategy, ElementRef, AfterViewInit, OnDestroy, HostListener, input, output, viewChild, model } from '@angular/core';
22
import { LoggerFactory, LoggerService, WindowRefService } from '@servoy/public';
33

44
import { ServoyBootstrapBaseTabPanel, Tab } from '../bts_basetabpanel';
@@ -16,11 +16,11 @@ export class ServoyBootstrapTabpanel extends ServoyBootstrapBaseTabPanel<HTMLULi
1616
readonly onTabCloseMethodID = input<(event: Event, tabIndex: number) => Promise<boolean>>(undefined);
1717

1818
readonly showTabCloseIcon = input<boolean>(undefined);
19-
closeIconStyleClass = signal<string>(undefined);
19+
closeIconStyleClass = model<string>(undefined);
2020
readonly cssPosition = input<{
21-
width: string;
22-
height: string;
23-
}>(undefined);
21+
width: string;
22+
height: string;
23+
}>(undefined);
2424
readonly containerStyleClass = input<string>(undefined);
2525

2626
containerStyle = { position: 'relative', minHeight: '0px', overflow: 'auto' };

0 commit comments

Comments
 (0)