Skip to content

Commit 0d5e30e

Browse files
committed
SVY-20819 use signals instead of @input in our components
1 parent d15c92b commit 0d5e30e

7 files changed

Lines changed: 1 addition & 8 deletions

File tree

components/projects/bootstrapcomponents/src/calendarinline/calendarinline.cy.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ describe('ServoyBootstrapCalendarinline', () => {
168168
cy.get('.day.active').should('have.attr', 'data-value', '2025-10-11').then(() => {
169169
const newDate = new Date(2025, 10, 14);
170170
wrapper.component.dataProviderID.set(newDate);
171-
wrapper.component.element._dataProviderID.set(newDate);
172171
expect(dataProviderIDChange).not.to.have.been.called;
173172
cy.get('.day.active').should('have.attr', 'data-value', '2025-10-14');
174173
});

components/projects/bootstrapcomponents/src/choicegroup/choicegroup.cy.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,6 @@ describe('ServoyBootstrapChoicegroup', () => {
215215
wrapper.component.dataProviderIDChange.subscribe(dataProviderIDChange);
216216
cy.get('input').should('have.not.checked').then(() => {
217217
wrapper.component.dataProviderID.set(1);
218-
wrapper.component.element._dataProviderID.set(1);
219218
cy.get('input').should('have.checked').then(() => {
220219
expect(dataProviderIDChange).not.to.have.been.called;
221220
});

components/projects/bootstrapcomponents/src/combobox/combobox.cy.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,6 @@ describe('ServoyBootstrapCombobox', () => {
226226
wrapper.component.dataProviderIDChange.subscribe(dataProviderIDChange);
227227
cy.get('button span').should('have.text', 'one').then(() => {
228228
wrapper.component.dataProviderID.set(2);
229-
wrapper.component.element._dataProviderID.set(2);
230229
cy.get('button span').should('have.text', 'two').then(() => {
231230
expect(dataProviderIDChange).not.to.have.been.called;
232231
});

components/projects/bootstrapcomponents/src/combobox/combobox.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ export class ServoyBootstrapCombobox extends ServoyBootstrapBasefield<HTMLDivEle
207207
}
208208

209209
svyOnChanges(changes: SimpleChanges) {
210+
super.svyOnChanges(changes);
210211
const valuelistID = this.valuelistID();
211212
this.valueComparator = valuelistID && valuelistID.isRealValueDate() ? this.dateValueCompare : this.valueCompare;
212213
const valuelistIDValue = this.valuelistID();
@@ -258,8 +259,6 @@ export class ServoyBootstrapCombobox extends ServoyBootstrapBasefield<HTMLDivEle
258259
}
259260
}
260261

261-
super.svyOnChanges(changes);
262-
263262
if (changes.readOnly || changes.enabled) {
264263
if (this.readOnly() || !this.enabled()) {
265264
this.renderer.setAttribute(this.getFocusElement(), 'disabled', 'disabled');

components/projects/bootstrapcomponents/src/floatlabelcombobox/floatlabelcombobox.cy.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ describe('ServoyFloatLabelBootstrapCombobox', () => {
231231
wrapper.component.dataProviderIDChange.subscribe(dataProviderIDChange);
232232
cy.get('button span').should('have.text', 'one').then(() => {
233233
wrapper.component.dataProviderID.set(2);
234-
wrapper.component.element._dataProviderID.set(2);
235234
cy.get('button span').should('have.text', 'two').then(() => {
236235
expect(dataProviderIDChange).not.to.have.been.called;
237236
});

components/projects/bootstrapcomponents/src/floatlabeltypeahead/floatlabeltypeahead.cy.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,6 @@ describe('ServoyFloatLabelBootstrapTypeahead', () => {
226226
wrapper.component.dataProviderIDChange.subscribe(dataProviderIDChange);
227227
cy.get('input').should('have.value', 'one').then(() => {
228228
wrapper.component.dataProviderID.set(2);
229-
wrapper.component.element._dataProviderID.set(2);
230229
expect(dataProviderIDChange).not.to.have.been.called;
231230
cy.get('input').should('have.value', 'two');
232231
});

components/projects/bootstrapcomponents/src/typeahead/typeahead.cy.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,6 @@ describe('ServoyBootstrapTypeahead', () => {
223223
wrapper.component.dataProviderIDChange.subscribe(dataProviderIDChange);
224224
cy.get('input').should('have.value', 'one').then(() => {
225225
wrapper.component.dataProviderID.set(2);
226-
wrapper.component.element._dataProviderID.set(2);
227226
expect(dataProviderIDChange).not.to.have.been.called;
228227
cy.get('input').should('have.value', 'two')
229228
});

0 commit comments

Comments
 (0)