only allow methods that matches shapes of object getters/setters

Author: mythz

src/ServiceStack.Text/AutoMappingUtils.cs

@@ -444,7 +444,6 @@ internal static AssignmentDefinition GetAssignmentDefinition(Type toType, Type f
 
             return AssignmentDefinitionCache.GetOrAdd(cacheKey, delegate
             {
-
                 var definition = new AssignmentDefinition
                 {
                     ToType = toType,
@@ -515,7 +514,7 @@ private static Dictionary<string, AssignmentMember> GetMembers(Type type, bool i
                     var parameterInfos = methodInfo.GetParameters();
                     if (isReadable)
                     {
-                        if (parameterInfos.Length == 0)
+                        if (parameterInfos.Length == 0 && methodInfo.ReturnType == typeof(object))
                         {
                             var name = info.Name.StartsWith("get_") ? info.Name.Substring(4) : info.Name;
                             if (!map.ContainsKey(name))
@@ -527,7 +526,8 @@ private static Dictionary<string, AssignmentMember> GetMembers(Type type, bool i
                     }
                     else
                     {
-                        if (parameterInfos.Length == 1 && methodInfo.ReturnType == typeof(void))
+                        if (parameterInfos.Length == 1 && methodInfo.ReturnType == typeof(void) && 
+                            methodInfo.GetParameters()[0].ParameterType == typeof(object))
                         {
                             var name = info.Name.StartsWith("set_") ? info.Name.Substring(4) : info.Name;
                             if (!map.ContainsKey(name))
@@ -539,7 +539,6 @@ private static Dictionary<string, AssignmentMember> GetMembers(Type type, bool i
                     }
                 }
             }
-
             return map;
         }
 

tests/ServiceStack.Text.Tests/AutoMappingTests.cs

@@ -1566,22 +1566,22 @@ public void Does_convert_nested_collections()
 
         public class TestMethod
         {
-            public void MyMethod(string myProp)
+            public void MyMethod()
             {
-                MyProp = myProp;
+                MyProp = nameof(MyProp);
             }
             public string MyProp { get; set; }
         }
-
+        
         public class TestMethod2
         {
-            public void MyMethod()
+            public void MyMethod(string myProp)
             {
                 MyProp = nameof(MyMethod);
             }
             public string MyProp { get; set; }
         }
-
+        
         [Test]
         public void Does_not_try_to_map_methods()
         {