bugfix

Author: gasse

src/browsergym/workarena/tasks/form.py

@@ -81,7 +81,7 @@ def _get_form(self, page):
         # ... augment with rendered metadata
         # XXX: Additional useful info is present in the rendered HTML. We extract it from there.
         for f in self.table_metadata:
-            loc = page.frame(name=self.js_prefix).locator(f"#sys_display\.{self.table_name}\.{f}")
+            loc = page.frame(name=self.js_prefix).locator(f"#sys_display.{self.table_name}.{f}")
             if loc.count() > 0:
                 # Check if the field is dependent on another field
                 self.table_metadata[f]["dependent_on_field"] = loc.first.get_attribute(

src/browsergym/workarena/tasks/scripts/validate.py

@@ -128,7 +128,8 @@ def validate_task(task_config, task_class, page=None):
         chat_messages = []
         task.cheat(page=page, chat_messages=chat_messages)
         page.wait_for_timeout(2000)
-        task_successful = task.validate(page, chat_messages)[1]
+        reward, done, _, _ = task.validate(page, chat_messages)
+        task_successful = done is True and reward == 1.0
         task.teardown()
         tries += 1
         if task_successful:

src/browsergym/workarena/tasks/service_catalog.py

@@ -23,11 +23,12 @@
     ORDER_DEVELOPMENT_LAPTOP_PC_TASK_CONFIG_PATH,
     ORDER_LOANER_LAPTOP_TASK_CONFIG_PATH,
 )
-from browsergym.workarena.api.requests import (
+from .utils.form import fill_text
+from ..api.requests import (
     get_request_by_id,
     db_delete_from_table,
 )
-from browsergym.workarena.tasks.base import AbstractServiceNowTask
+from .base import AbstractServiceNowTask
 
 ADDITIONAL_SOFTWARE = [
     "Slack",
@@ -310,18 +311,10 @@ def cheat(self, page: Page, chat_messages: list[str]) -> None:
                 element_id = element_control.get_attribute("id")  # this look superfluous
                 text_element = iframe.query_selector(f'[id="{element_id}"]')
                 text_element.click()
-                from .utils.form import fill_text
-
                 fill_text(page=page, input_field=text_element, value=value, iframe=iframe)
+
             elif control_type == "select-one":
-                select_options = iframe.query_selector(f'select[id="{element_id}"]', strict=True)
-                select_options.click()
-                options = select_options.query_selector_all("option")
-                for option in options:
-                    if option.inner_text().startswith(value):
-                        page.keyboard.press("Enter")
-                        break
-                    page.keyboard.press("ArrowDown")
+                iframe.locator(f"id={element_id}").select_option(value)
             else:
                 raise ValueError(f"Unknown control type {control_type}")
 
@@ -475,10 +468,13 @@ def validate(self, page: Page, chat_messages: list[str]) -> tuple[int, bool, str
 
 
 def option_match_heuristic(value, option):
-    value = str(value).lower()
-    option = str(option).lower()
-    option = option.replace("_", " ")
-    return value == option
+    def _process(x):
+        x = str(x).lower()
+        x = x.replace("_", "")
+        x = x.replace(" ", "")
+        return x
+
+    return _process(value) == _process(option)
 
 
 class OrderDeveloperLaptopTask(OrderHardwareTask):

tests/test_random_config_generation.py

@@ -90,7 +90,9 @@ def test_cheat_from_random_config(task_entrypoint, random_seed: int, page: Page)
     task = task_entrypoint()
     task._generate_random_config(seed=random_seed, page=page)
     chat_messages = []
-    assert task.validate(page, chat_messages)[1] is False
+    reward, done, message, info = task.validate(page, chat_messages)
+    assert done is False and reward == 0.0
     task.cheat(page=page, chat_messages=chat_messages)
-    assert task.validate(page, chat_messages)[1] is True
+    reward, done, message, info = task.validate(page, chat_messages)
+    assert done is True and reward == 1.0
     task.teardown()