Fix instance consistency in KnowledgeBaseSearchTask

aldro61 · claude · aldro61 · commit 6d4194fcfe6b · 2025-12-06T09:57:45.000-08:00
Resolves issue #119 where KnowledgeBaseSearchTask could use different ServiceNow instances within the same task when checking knowledge base integrity. Changed line 84 to use self.instance instead of creating a new SNowInstance(), ensuring the same instance is used throughout the task lifecycle. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
diff --git a/src/browsergym/workarena/tasks/knowledge.py b/src/browsergym/workarena/tasks/knowledge.py
@@ -81,7 +81,7 @@ def __init__(
             )
         else:
             _, requires_install, requires_delete = check_knowledge_base(
-                SNowInstance(),  # instance would be the non-admin instance here and this might break in case user does not have required permissions
+                self.instance,  # Use the instance passed to the task
                 kb_name=KB_NAME,
                 kb_data=self.kb_entries,  # Need admin permissions to check
             )

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ def __init__(`
`81`	`81`	`)`
`82`	`82`	`else:`
`83`	`83`	`_, requires_install, requires_delete = check_knowledge_base(`
`84`		`- SNowInstance(), # instance would be the non-admin instance here and this might break in case user does not have required permissions`
	`84`	`+ self.instance, # Use the instance passed to the task`
`85`	`85`	`kb_name=KB_NAME,`
`86`	`86`	`kb_data=self.kb_entries, # Need admin permissions to check`
`87`	`87`	`)`