Added basic tests for Porter::importAsync() and importOneAsync().

Author: Bilge

composer.json

@@ -19,7 +19,7 @@
   },
   "require-dev": {
     "phpunit/phpunit": "^7.1.3",
-    "mockery/mockery": "^1"
+    "bilge/mockery": "dev-issue-871"
   },
   "suggest" : {
     "connectors/http": "Provides an HTTP connector for Porter providers.",

src/Collection/RecordCollection.php

@@ -21,10 +21,7 @@ public function current(): array
         return $this->records->current();
     }
 
-    /**
-     * @return void
-     */
-    public function next()
+    public function next(): void
     {
         $this->records->next();
     }
@@ -37,34 +34,25 @@ public function key()
         return $this->records->key();
     }
 
-    /**
-     * @return bool
-     */
-    public function valid()
+    public function valid(): bool
     {
         return $this->records->valid();
     }
 
-    /**
-     * @return void
-     */
-    public function rewind()
+    public function rewind(): void
     {
         $this->records->rewind();
     }
 
-    /**
-     * @return RecordCollection|null
-     */
-    public function getPreviousCollection()
+    public function getPreviousCollection(): ?RecordCollection
     {
         return $this->previousCollection;
     }
 
-    public function findFirstCollection()
+    public function findFirstCollection(): ?RecordCollection
     {
         do {
-            $previous = isset($nextPrevious) ? $nextPrevious : $this->getPreviousCollection();
+            $previous = $nextPrevious ?? $this->getPreviousCollection();
         } while ($previous && $nextPrevious = $previous->getPreviousCollection());
 
         return $previous ?: $this;

src/Porter.php

@@ -153,11 +153,11 @@ public function importOneAsync(AsyncImportSpecification $specification): Promise
         return \Amp\call(function () use ($specification) {
             $results = $this->importAsync($specification);
 
-            \Amp\Promise\rethrow(yield $results->advance());
+            yield $results->advance();
 
             $one = $results->getCurrent();
 
-            if (yield $results->advance() !== null) {
+            if ((yield $results->advance()) !== false) {
                 throw new ImportException('Cannot import one: more than one record imported.');
             }
 

src/Specification/AsyncImportSpecification.php

@@ -18,6 +18,8 @@ public function __construct(AsyncResource $resource)
         }
 
         parent::__construct($resource);
+
+        $this->asyncResource = $resource;
     }
 
     public function __clone()

test/Integration/Porter/AsyncPorterTest.php

@@ -0,0 +1,38 @@
+<?php
+declare(strict_types=1);
+
+namespace ScriptFUSIONTest\Integration\Porter;
+
+use Amp\Loop;
+use ScriptFUSION\Porter\Porter;
+use ScriptFUSION\Porter\Specification\AsyncImportSpecification;
+
+/**
+ * @see Porter
+ */
+final class AsyncPorterTest extends PorterTest
+{
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        $this->specification = new AsyncImportSpecification($this->resource);
+    }
+
+    public function testImportAsync(): void
+    {
+        Loop::run(function () {
+            $records = $this->porter->importAsync($this->specification);
+            yield $records->advance();
+
+            self::assertSame(['foo'], $records->getCurrent());
+        });
+    }
+
+    public function testImportOneAsync(): void
+    {
+        Loop::run(function () {
+            self::assertSame(['foo'], yield $this->porter->importOneAsync($this->specification));
+        });
+    }
+}