Updated retry library from ^2 -> ^2.1 for promise-based exception handlers.

Deprecated specification context.
Minor fixes.

Author: Bilge

composer.json

@@ -11,15 +11,15 @@
   "require": {
     "php": "^7.1",
     "scriptfusion/static-class": "^1",
-    "scriptfusion/retry": "^2",
+    "scriptfusion/retry": "^2.1",
     "scriptfusion/retry-exception-handlers": "^1.1",
     "amphp/amp": "^2",
     "psr/container": "^1",
     "psr/cache": "^1"
   },
   "require-dev": {
     "phpunit/phpunit": "^7.1.3",
-    "bilge/mockery": "dev-issue-871"
+    "mockery/mockery": "^1.1"
   },
   "suggest" : {
     "connectors/http": "Provides an HTTP connector for Porter providers.",

src/Collection/CountableRecordsTrait.php

@@ -15,6 +15,6 @@ public function count(): int
 
     private function setCount(int $count): void
     {
-        $this->count = $count | 0;
+        $this->count = $count;
     }
 }

src/Connector/ImportConnector.php

@@ -11,7 +11,7 @@
 
 /**
  * Connector whose lifecycle is synchronised with an import operation. Ensures correct ConnectionContext is delivered
- * to the wrapped connector.
+ * to the wrapped connector and intercepts failed connections to facilitate automatic retries.
  *
  * Do not store references to this connector that would prevent it expiring when an import operation ends.
  *
@@ -111,12 +111,12 @@ private function createExceptionHandler(): \Closure
      * Invokes the specified fetch exception handler, cloning it if required.
      *
      * @param RecoverableExceptionHandler $handler Fetch exception handler.
-     * @param \Exception $exception Exception to pass to the handler.
+     * @param RecoverableException $recoverableException Recoverable exception to pass to the handler.
      * @param bool $cloned False if handler requires cloning, true if handler has already been cloned.
      */
     private static function invokeHandler(
         RecoverableExceptionHandler &$handler,
-        \Exception $exception,
+        RecoverableException $recoverableException,
         bool &$cloned
     ): void {
         if (!$cloned && !$handler instanceof StatelessRecoverableExceptionHandler) {
@@ -125,7 +125,7 @@ private static function invokeHandler(
             $cloned = true;
         }
 
-        $handler($exception);
+        $handler($recoverableException);
     }
 
     /**

src/Connector/Recoverable/ExponentialSleepRecoverableExceptionHandler.php

@@ -20,9 +20,9 @@ class ExponentialSleepRecoverableExceptionHandler implements RecoverableExceptio
      *
      * @param int $initialDelay Initial delay.
      */
-    public function __construct($initialDelay = ExponentialBackoffExceptionHandler::DEFAULT_COEFFICIENT)
+    public function __construct(int $initialDelay = ExponentialBackoffExceptionHandler::DEFAULT_COEFFICIENT)
     {
-        $this->initialDelay = $initialDelay | 0;
+        $this->initialDelay = $initialDelay;
     }
 
     public function initialize(): void

src/Connector/Recoverable/RecoverableExceptionHandler.php

@@ -27,6 +27,8 @@ public function initialize(): void;
 
     /**
      * Handles a recoverable exception.
+     *
+     * @return mixed
      */
-    public function __invoke(RecoverableException $exception): void;
+    public function __invoke(RecoverableException $exception);
 }

src/Specification/ImportSpecification.php

@@ -167,6 +167,8 @@ private function hasTransformer(Transformer $transformer): bool
 
     /**
      * @return mixed
+     *
+     * @deprecated TODO: Evaluate whether context can be removed.
      */
     final public function getContext()
     {
@@ -177,6 +179,8 @@ final public function getContext()
      * @param mixed $context
      *
      * @return $this
+     *
+     * @deprecated TODO: Evaluate whether context can be removed.
      */
     final public function setContext($context): self
     {