Added tests for more Porter::fetchAsync() exception states.

Author: Bilge

test/Integration/Porter/PorterAsyncTest.php

@@ -6,13 +6,16 @@
 use Amp\Iterator;
 use Amp\Loop;
 use Amp\Producer;
+use ScriptFUSION\Porter\Connector\AsyncConnector;
+use ScriptFUSION\Porter\Connector\ConnectorOptions;
+use ScriptFUSION\Porter\ForeignResourceException;
 use ScriptFUSION\Porter\ImportException;
 use ScriptFUSION\Porter\IncompatibleProviderException;
 use ScriptFUSION\Porter\Porter;
-use ScriptFUSION\Porter\Provider\AsyncProvider;
 use ScriptFUSION\Porter\Provider\Provider;
 use ScriptFUSION\Porter\Specification\AsyncImportSpecification;
 use ScriptFUSION\Porter\Transform\FilterTransformer;
+use ScriptFUSIONTest\MockFactory;
 
 /**
  * @see Porter
@@ -67,6 +70,30 @@ public function testImportIncompatibleProvider(): \Generator
         yield $this->porter->importAsync($this->specification->setProviderName($providerName));
     }
 
+    /**
+     * Tests that when a resource's provider class name does not match the provider an exception is thrown.
+     */
+    public function testImportForeignResource(): \Generator
+    {
+        // Replace existing provider with a different one.
+        $this->registerProvider(MockFactory::mockProvider(), \get_class($this->provider));
+
+        $this->expectException(ForeignResourceException::class);
+        yield $this->porter->importAsync($this->specification);
+    }
+
+    /**
+     * Tests that when importing using a connector that exports options, but no clone method, an exception is thrown.
+     */
+    public function testImportConnectorWithOptions(): void
+    {
+        $this->provider->shouldReceive('getAsyncConnector')
+            ->andReturn(\Mockery::mock(AsyncConnector::class, ConnectorOptions::class));
+
+        $this->expectException(\LogicException::class);
+        $this->porter->importAsync($this->specification);
+    }
+
     /**
      * Tests that a stack of async filter transformers are applied correctly.
      * The order is deterministic because filters yield immediately.

test/Integration/Porter/PorterSyncTest.php

@@ -131,7 +131,7 @@ public function testImportCustomProviderName(): void
     }
 
     /**
-     * Tests that when a resource does not return an iterator, ImportException is thrown.
+     * Tests that when a resource does not return an iterator, an exception is thrown.
      */
     public function testImportFailure(): void
     {

test/MockFactory.php

@@ -43,6 +43,7 @@ public static function mockProvider()
                         ->andReturn(new Delayed(0, 'foo'))
                         ->getMock()
                 )
+                ->byDefault()
             ->getMock()
         ;
     }