Avoid double-free

ledyba-z · ledyba-z · commit 3bd036e2d878 · 2020-03-05T14:54:39.000+09:00
diff --git a/SDWebImageAVIFCoder/Classes/SDImageAVIFCoder.m b/SDWebImageAVIFCoder/Classes/SDImageAVIFCoder.m
@@ -451,6 +451,7 @@ static CGImageRef CreateImage8(avifImage * avif) {
                 goto end_alpha_mono;
             }
             result = CreateImageFromBuffer(avif, &outBuffer);
+            outBufferData = NULL;
         end_alpha_mono:
             free(tmpBufferData);
             free(monoBufferData);
@@ -462,6 +463,7 @@ static CGImageRef CreateImage8(avifImage * avif) {
                 goto end_alpha_color;
             }
             result = CreateImageFromBuffer(avif, &argbBuffer);
+            outBufferData = NULL;
         end_alpha_color:
             goto end_alpha;
         }
@@ -486,6 +488,7 @@ static CGImageRef CreateImage8(avifImage * avif) {
                 goto end_no_alpha_mono;
             }
             result = CreateImageFromBuffer(avif, &outBuffer);
+            outBufferData = NULL;
         end_no_alpha_mono:
             free(tmpBufferData);
             goto end_no_alpha;
@@ -496,6 +499,7 @@ static CGImageRef CreateImage8(avifImage * avif) {
                 goto end_no_alpha_color;
             }
             result = CreateImageFromBuffer(avif, &outBuffer);
+            outBufferData = NULL;
         end_no_alpha_color:
             goto end_no_alpha;
         }

Original file line number	Diff line number	Diff line change
`@@ -451,6 +451,7 @@ static CGImageRef CreateImage8(avifImage * avif) {`
`451`	`451`	`goto end_alpha_mono;`
`452`	`452`	`}`
`453`	`453`	`result = CreateImageFromBuffer(avif, &outBuffer);`
	`454`	`+ outBufferData = NULL;`
`454`	`455`	`end_alpha_mono:`
`455`	`456`	`free(tmpBufferData);`
`456`	`457`	`free(monoBufferData);`
`@@ -462,6 +463,7 @@ static CGImageRef CreateImage8(avifImage * avif) {`
`462`	`463`	`goto end_alpha_color;`
`463`	`464`	`}`
`464`	`465`	`result = CreateImageFromBuffer(avif, &argbBuffer);`
	`466`	`+ outBufferData = NULL;`
`465`	`467`	`end_alpha_color:`
`466`	`468`	`goto end_alpha;`
`467`	`469`	`}`
`@@ -486,6 +488,7 @@ static CGImageRef CreateImage8(avifImage * avif) {`
`486`	`488`	`goto end_no_alpha_mono;`
`487`	`489`	`}`
`488`	`490`	`result = CreateImageFromBuffer(avif, &outBuffer);`
	`491`	`+ outBufferData = NULL;`
`489`	`492`	`end_no_alpha_mono:`
`490`	`493`	`free(tmpBufferData);`
`491`	`494`	`goto end_no_alpha;`
`@@ -496,6 +499,7 @@ static CGImageRef CreateImage8(avifImage * avif) {`
`496`	`499`	`goto end_no_alpha_color;`
`497`	`500`	`}`
`498`	`501`	`result = CreateImageFromBuffer(avif, &outBuffer);`
	`502`	`+ outBufferData = NULL;`
`499`	`503`	`end_no_alpha_color:`
`500`	`504`	`goto end_no_alpha;`
`501`	`505`	`}`