fix(warnings): fix all warnings and remove dead code

Author: Akinator31

rustmail/src/api/handler/auth/callback.rs

@@ -17,8 +17,8 @@ pub struct AuthRequest {
 #[derive(serde::Deserialize, Debug)]
 struct DiscordUser {
     id: String,
-    username: String,
-    discriminator: String,
+    _username: String,
+    _discriminator: String,
     avatar: Option<String>,
 }
 

rustmail/src/api/handler/panel/panel.rs

@@ -4,8 +4,6 @@ use axum::response::IntoResponse;
 use std::sync::Arc;
 use tokio::sync::Mutex;
 
-pub async fn handle_panel_check(
-    State(bot_state): State<Arc<Mutex<BotState>>>,
-) -> impl IntoResponse {
+pub async fn handle_panel_check(State(..): State<Arc<Mutex<BotState>>>) -> impl IntoResponse {
     axum::response::Json(serde_json::json!({ "authorized": true }))
 }

rustmail/src/bot.rs

@@ -235,7 +235,6 @@ pub async fn run_bot(
 
                         let _ = resp.send(is_member);
                     }
-                    _ => {}
                 }
             }
 

rustmail/src/commands/alert/common.rs

@@ -7,19 +7,14 @@ use serenity::all::{CommandInteraction, Context, CreateInteractionResponse, Mess
 use std::collections::HashMap;
 
 pub async fn get_thread_user_id_from_msg(
-    ctx: &Context,
     msg: &Message,
-    config: &Config,
     pool: &sqlx::SqlitePool,
 ) -> ModmailResult<i64> {
     let channel_id = msg.channel_id.to_string();
 
     match get_user_id_from_channel_id(&channel_id, pool).await {
         Some(uid) => Ok(uid),
-        None => {
-            send_alert_message(ctx, msg, config, "alert.not_in_thread", None).await;
-            Err(common::validation_failed("Not in a thread"))
-        }
+        None => Err(ModmailError::Command(CommandError::NotInThread())),
     }
 }
 
@@ -78,7 +73,18 @@ pub async fn handle_cancel_alert_from_msg(
     let mut params = HashMap::new();
     params.insert("user".to_string(), format!("<@{}>", user_id));
 
-    send_alert_message(ctx, msg, config, "alert.cancel_confirmation", Some(&params)).await;
+    let _ = MessageBuilder::system_message(ctx, config)
+        .translated_content(
+            "alert.cancel_confirmation",
+            Some(&params),
+            Some(msg.author.id),
+            msg.guild_id.map(|g| g.get()),
+        )
+        .await
+        .to_channel(msg.channel_id)
+        .send(true)
+        .await;
+
     Ok(())
 }
 
@@ -120,15 +126,25 @@ pub async fn handle_set_alert_from_msg(
     user_id: i64,
     pool: &sqlx::SqlitePool,
 ) -> ModmailResult<()> {
-    if let Err(e) = set_alert_for_staff(msg.author.id, user_id, pool).await {
-        send_alert_message(ctx, msg, config, "alert.set_failed", None).await;
-        return Ok(());
+    if let Err(..) = set_alert_for_staff(msg.author.id, user_id, pool).await {
+        return Err(ModmailError::Command(CommandError::AlertSetFailed));
     }
 
     let mut params = HashMap::new();
     params.insert("user".to_string(), format!("<@{}>", user_id));
 
-    send_alert_message(ctx, msg, config, "alert.confirmation", Some(&params)).await;
+    let _ = MessageBuilder::system_message(ctx, config)
+        .translated_content(
+            "alert.confirmation",
+            Some(&params),
+            Some(msg.author.id),
+            msg.guild_id.map(|g| g.get()),
+        )
+        .await
+        .to_channel(msg.channel_id)
+        .send(true)
+        .await;
+
     Ok(())
 }
 
@@ -165,26 +181,6 @@ pub async fn handle_set_alert_from_command(
     }
 }
 
-pub async fn send_alert_message(
-    ctx: &Context,
-    msg: &Message,
-    config: &Config,
-    message_key: &str,
-    params: Option<&HashMap<String, String>>,
-) {
-    let _ = MessageBuilder::system_message(ctx, config)
-        .translated_content(
-            message_key,
-            params,
-            Some(msg.author.id),
-            msg.guild_id.map(|g| g.get()),
-        )
-        .await
-        .to_channel(msg.channel_id)
-        .send(true)
-        .await;
-}
-
 pub async fn extract_alert_action(msg: &Message, config: &Config) -> bool {
     let content = msg.content.trim();
     let prefix = &config.command.prefix;

rustmail/src/commands/alert/text_command/alert.rs

@@ -16,7 +16,7 @@ pub async fn alert(
         .as_ref()
         .ok_or_else(database_connection_failed)?;
 
-    let user_id = get_thread_user_id_from_msg(&ctx, &msg, config, pool).await?;
+    let user_id = get_thread_user_id_from_msg(&msg, pool).await?;
     let is_cancel = extract_alert_action(&msg, config).await;
 
     if is_cancel {

rustmail/src/commands/delete/common.rs

@@ -1,4 +1,3 @@
-use crate::prelude::commands::*;
 use crate::prelude::config::*;
 use crate::prelude::db::*;
 use crate::prelude::errors::*;

rustmail/src/commands/edit/message_ops.rs

@@ -1,4 +1,3 @@
-use crate::prelude::commands::*;
 use crate::prelude::config::*;
 use crate::prelude::db::*;
 use crate::prelude::errors::*;

rustmail/src/commands/logs/text_command/logs.rs

@@ -93,7 +93,6 @@ pub async fn handle_logs_from_user_id(
     pagination_store.lock().await.insert(
         session_id.clone(),
         PaginationContext {
-            user_id: user_id.to_string(),
             logs,
             current_page: page,
             message_id: response.id,

rustmail/src/commands/move_thread/common.rs

@@ -1,9 +1,6 @@
 use crate::prelude::config::*;
 use crate::prelude::db::*;
-use crate::prelude::i18n::*;
-use crate::prelude::utils::*;
 use serenity::all::{ChannelId, CommandInteraction, Context, EditChannel, GuildId, Message};
-use std::collections::HashMap;
 
 pub async fn is_in_thread(msg: &Message, pool: &sqlx::SqlitePool) -> bool {
     let channel_id = msg.channel_id.to_string();

rustmail/src/commands/ping/slash_command/ping.rs

@@ -5,7 +5,6 @@ use crate::errors::{DiscordError, ModmailError, ModmailResult};
 use crate::handlers::InteractionHandler;
 use crate::i18n::get_translated_message;
 use crate::utils::{MessageBuilder, defer_response};
-use chrono::Utc;
 use serenity::FutureExt;
 use serenity::all::{CommandInteraction, Context, CreateCommand, ResolvedOption};
 use std::collections::HashMap;